fix(redis-session): preserve created_at across writes#3202
Merged
seratch merged 2 commits intoopenai:mainfrom May 9, 2026
Merged
fix(redis-session): preserve created_at across writes#3202seratch merged 2 commits intoopenai:mainfrom
seratch merged 2 commits intoopenai:mainfrom
Conversation
`add_items` rewrote the session metadata hash with a fresh `created_at` value on every call, so the timestamp tracked the most recent write rather than the actual session creation time. Use `HSETNX` for `created_at` so it is written only on the first call.
3 tasks
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RedisSession.add_itemsrewrites the session metadata hash withmapping={"created_at": str(int(time.time())), ...}on every call. BecauseHSETwith a mapping overwrites every field,created_atis reset to the current timestamp on every subsequent write — making it indistinguishable fromupdated_atand useless as a session-creation timestamp.This is the same class of metadata-integrity bug as #3173 (Dapr) and #3175 (encrypted-session counts), in a sibling backend.
Fix
Write
session_idwithHSET,created_atwithHSETNX(set only if not present), andupdated_atwithHSET. Reuse a singlenowvalue for both writes socreated_at == updated_aton the very first call.Diff: 15 net lines in
redis_session.py, plus a focused regression test.Test plan
test_add_items_preserves_created_at_metadatafails onmain, passes with the fixtests/extensions/memory/suite passes locally (83 passed, 4 skipped)