-
Notifications
You must be signed in to change notification settings - Fork 4.8k
feat(auth): add AWS Bedrock token provider #3135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tbuatois
wants to merge
7
commits into
openai:main
Choose a base branch
from
tbuatois:feat/aws-bedrock-token-provider
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+232
−2
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a9f9f2c
feat(auth): add AWS Bedrock token provider
tbuatois cc64a8b
fix(auth): default Bedrock token_duration to 1h to match temporary cr…
tbuatois aa1add5
fix(auth): remove token caching in aws_bedrock_token_provider, cache …
tbuatois 71df8f4
fix(auth): fully mock botocore in tests so they run in CI without ope…
tbuatois 0d4fe24
fix(auth): add async_aws_bedrock_token_provider for AsyncOpenAI, full…
tbuatois f7c8cf0
fix(docs): correct Bedrock base_url to bedrock-mantle and warn on reg…
tbuatois 356ccf4
refactor(auth): remove token_duration from Bedrock providers, use bot…
tbuatois File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aws_bedrock_token_provider()currently returns a synchronousCallable[[], str], butAsyncOpenAIunconditionally awaitsapi_keyproviders inAsyncOpenAI._refresh_api_key. If an async user passes this new helper (the same way as the sync example), requests fail at runtime with aTypeErrorbecausestris not awaitable. This makes the new Bedrock auth path unusable for async clients unless users write their own wrapper.Useful? React with 👍 / 👎.