fix(openapi-fetch): replace Math.random() with deterministic counter for request IDs#2763
Open
Nedunchezhiyan-M wants to merge 2 commits intoopenapi-ts:mainfrom
Open
fix(openapi-fetch): replace Math.random() with deterministic counter for request IDs#2763Nedunchezhiyan-M wants to merge 2 commits intoopenapi-ts:mainfrom
Nedunchezhiyan-M wants to merge 2 commits intoopenapi-ts:mainfrom
Conversation
…for request IDs Math.random() is a non-deterministic side effect that can interfere with frameworks that cache or deduplicate fetch calls (e.g. Next.js React Server Components). Replace with a monotonic counter that produces unique IDs within a process but is deterministic across runs, eliminating the unpredictable side effect. Fixes openapi-ts#2486
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: e2e0cbf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
randomID()was usingMath.random()to generate per-request middleware correlation IDsMath.random()is a non-deterministic side effect that can conflict with frameworks that cache or deduplicatefetch()calls (e.g. Next.js React Server Components)++_idCounter) that produces unique IDs within a process but is deterministic across runs, eliminating the unpredictable side effectTest plan
onRequestandonResponseFixes #2486