Skip to content

update cert injection annotations to beta#2046

Open
lance5890 wants to merge 1 commit intoopenshift:mainfrom
lance5890:update_cert_injection_beta
Open

update cert injection annotations to beta#2046
lance5890 wants to merge 1 commit intoopenshift:mainfrom
lance5890:update_cert_injection_beta

Conversation

@lance5890
Copy link
Contributor

@lance5890 lance5890 commented Feb 12, 2026

apiVersion: v1
kind: Service
metadata:
  annotations:
    exclude.release.openshift.io/internal-openshift-hosted: "true"
    include.release.openshift.io/self-managed-high-availability: "true"
    include.release.openshift.io/single-node-developer: "true"
    service.alpha.openshift.io/serving-cert-secret-name: kube-apiserver-operator-serving-cert
    service.alpha.openshift.io/serving-cert-signed-by: openshift-service-serving-signer@1770628411
    service.beta.openshift.io/serving-cert-signed-by: openshift-service-serving-signer@1770628411

@coderabbitai
Copy link

coderabbitai bot commented Feb 12, 2026

Walkthrough

The OpenShift Service manifest annotation key for serving certificate secret configuration is updated from the alpha API version to the beta API version, while the configuration value remains unchanged.

Changes

Cohort / File(s) Summary
Service Manifest Annotation Update
manifests/0000_20_kube-apiserver-operator_02_service.yaml
Serving certificate annotation key updated from service.alpha.openshift.io/serving-cert-secret-name to service.beta.openshift.io/serving-cert-secret-name.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lance5890
Once this PR has been reviewed and has the lgtm label, please assign p0lyn0mial for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 12, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2026

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant