[release-4.21] OCPBUGS-80931: Hide filter category selector when only one filter exists#16199
Conversation
|
@rhamilto: This pull request references Jira Issue OCPBUGS-80931, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/approve |
|
/jira refresh |
|
@rhamilto: This pull request references Jira Issue OCPBUGS-80931, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
Adds CSS to hide the filter category dropdown selector when there's only one filter type available in ConsoleDataView, improving UX by removing unnecessary UI elements. Changes: - Create ConsoleDataView.scss with `.co-console-data-view-single-filter` class - Apply class to DataView component when single filter is present - Import CSS utilities and stylesheet in ConsoleDataView.tsx - Add Cypress test to verify category selector is hidden for both text and select filter types - Add reusable test helper `verifySingleFilterCategoryHidden` The CSS uses `!important` to ensure the rule works across all breakpoints and targets the first child of the filter group (the category selector). Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
|
@sg00dwin, please retag after rebase. |
|
/jira refresh |
|
@rhamilto: This pull request references Jira Issue OCPBUGS-80931, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/verified by @sg00dwin |
|
@sg00dwin: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhamilto, sg00dwin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@rhamilto: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
8d87d59
into
openshift:release-4.21
|
@rhamilto: Jira Issue Verification Checks: Jira Issue OCPBUGS-80931 Jira Issue OCPBUGS-80931 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Summary
Cherry-pick of OCPBUGS-78543 to release-4.21 branch. This improves UX by hiding the filter category dropdown selector when there's only one filter type available in ConsoleDataView.
Changes
ConsoleDataView.scsswith.co-console-data-view-single-filterclassverifySingleFilterCategoryHiddenThe CSS uses
!importantto ensure the rule works across all breakpoints and targets the first child of the filter group (the category selector).Test plan
🤖 Generated with Claude Code