Skip to content

[release-4.21] OCPBUGS-80931: Hide filter category selector when only one filter exists#16199

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
rhamilto:OCPBUGS-80931
Mar 31, 2026
Merged

[release-4.21] OCPBUGS-80931: Hide filter category selector when only one filter exists#16199
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.21from
rhamilto:OCPBUGS-80931

Conversation

@rhamilto
Copy link
Copy Markdown
Member

Summary

Cherry-pick of OCPBUGS-78543 to release-4.21 branch. This improves UX by hiding the filter category dropdown selector when there's only one filter type available in ConsoleDataView.

Changes

  • Added ConsoleDataView.scss with .co-console-data-view-single-filter class
  • Applied class to DataView component when single filter is present
  • Imported CSS utilities and stylesheet in ConsoleDataView.tsx
  • Added Cypress test to verify category selector is hidden for both text and select filter types
  • Added reusable test helper verifySingleFilterCategoryHidden
  • Updated alertmanager receiver tests for consistency

The CSS uses !important to ensure the rule works across all breakpoints and targets the first child of the filter group (the category selector).

Test plan

  • Verify filter category selector is hidden when only one filter exists
  • Test with text-only filter (e.g., AlertmanagerConfig page)
  • Test with select-only filter (e.g., Pod search page)
  • Verify multiple filters still show the category selector
  • Run Cypress tests to ensure new tests pass

🤖 Generated with Claude Code

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 26, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-80931, which is invalid:

  • expected dependent Jira Issue OCPBUGS-78543 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Cherry-pick of OCPBUGS-78543 to release-4.21 branch. This improves UX by hiding the filter category dropdown selector when there's only one filter type available in ConsoleDataView.

Changes

  • Added ConsoleDataView.scss with .co-console-data-view-single-filter class
  • Applied class to DataView component when single filter is present
  • Imported CSS utilities and stylesheet in ConsoleDataView.tsx
  • Added Cypress test to verify category selector is hidden for both text and select filter types
  • Added reusable test helper verifySingleFilterCategoryHidden
  • Updated alertmanager receiver tests for consistency

The CSS uses !important to ensure the rule works across all breakpoints and targets the first child of the filter group (the category selector).

Test plan

  • Verify filter category selector is hidden when only one filter exists
  • Test with text-only filter (e.g., AlertmanagerConfig page)
  • Test with select-only filter (e.g., Pod search page)
  • Verify multiple filters still show the category selector
  • Run Cypress tests to ensure new tests pass

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4228ad05-58f0-4c0b-b5e3-db8731177317

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@rhamilto rhamilto changed the title OCPBUGS-80931: Hide filter category selector when only one filter exists [release-4.21] OCPBUGS-80931: Hide filter category selector when only one filter exists Mar 26, 2026
@openshift-ci openshift-ci bot requested review from TheRealJon and spadgett March 26, 2026 12:05
@openshift-ci openshift-ci bot added component/core Related to console core functionality kind/cypress Related to Cypress e2e integration testing approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 26, 2026
@rhamilto
Copy link
Copy Markdown
Member Author

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 26, 2026
@rhamilto
Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-80931, which is invalid:

  • expected dependent Jira Issue OCPBUGS-78543 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sg00dwin sg00dwin added the verified Signifies that the PR passed pre-merge verification criteria label Mar 26, 2026
@sg00dwin
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 26, 2026
Adds CSS to hide the filter category dropdown selector when there's only
one filter type available in ConsoleDataView, improving UX by removing
unnecessary UI elements.

Changes:
- Create ConsoleDataView.scss with `.co-console-data-view-single-filter` class
- Apply class to DataView component when single filter is present
- Import CSS utilities and stylesheet in ConsoleDataView.tsx
- Add Cypress test to verify category selector is hidden for both text and select filter types
- Add reusable test helper `verifySingleFilterCategoryHidden`

The CSS uses `!important` to ensure the rule works across all breakpoints
and targets the first child of the filter group (the category selector).

Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Mar 30, 2026
@rhamilto
Copy link
Copy Markdown
Member Author

@sg00dwin, please retag after rebase.

@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 30, 2026
@rhamilto
Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 31, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-80931, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-78543 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-78543 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 31, 2026
@sg00dwin
Copy link
Copy Markdown
Member

/lgtm

@sg00dwin
Copy link
Copy Markdown
Member

/verified by @sg00dwin

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 31, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@sg00dwin: This PR has been marked as verified by @sg00dwin.

Details

In response to this:

/verified by @sg00dwin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhamilto
Copy link
Copy Markdown
Member Author

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8d87d59 into openshift:release-4.21 Mar 31, 2026
8 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhamilto: Jira Issue Verification Checks: Jira Issue OCPBUGS-80931
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-80931 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary

Cherry-pick of OCPBUGS-78543 to release-4.21 branch. This improves UX by hiding the filter category dropdown selector when there's only one filter type available in ConsoleDataView.

Changes

  • Added ConsoleDataView.scss with .co-console-data-view-single-filter class
  • Applied class to DataView component when single filter is present
  • Imported CSS utilities and stylesheet in ConsoleDataView.tsx
  • Added Cypress test to verify category selector is hidden for both text and select filter types
  • Added reusable test helper verifySingleFilterCategoryHidden
  • Updated alertmanager receiver tests for consistency

The CSS uses !important to ensure the rule works across all breakpoints and targets the first child of the filter group (the category selector).

Test plan

  • Verify filter category selector is hidden when only one filter exists
  • Test with text-only filter (e.g., AlertmanagerConfig page)
  • Test with select-only filter (e.g., Pod search page)
  • Verify multiple filters still show the category selector
  • Run Cypress tests to ensure new tests pass

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto rhamilto deleted the OCPBUGS-80931 branch April 1, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/core Related to console core functionality jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants