OCPBUGS-78539: revert temporary crash toleration for dns-operator

[jparrill]

Summary

• Reverts the temporary e2e crash toleration for dns-operator added in OCPBUGS-78539: chore(e2e): add temporary crash toleration for dns-operator #7978
• The toleration was a temporary workaround while waiting for the updated cluster-dns-operator manifests to reach the OCP payload in nightly builds
• The fix has now landed in the payload, so the toleration is no longer needed

References

• https://redhat.atlassian.net/browse/OCPBUGS-78539
• Reverts OCPBUGS-78539: chore(e2e): add temporary crash toleration for dns-operator #7978

Test plan

• Verify e2e tests pass without the dns-operator crash toleration

Summary by CodeRabbit

• Chores
  • Updated internal tolerance configurations for pod restart behavior.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@jparrill: This pull request references Jira Issue OCPBUGS-78539, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Reverts the temporary e2e crash toleration for dns-operator added in OCPBUGS-78539: chore(e2e): add temporary crash toleration for dns-operator #7978
• The toleration was a temporary workaround while waiting for the updated cluster-dns-operator manifests to reach the OCP payload in nightly builds
• The fix has now landed in the payload, so the toleration is no longer needed

References

• https://redhat.atlassian.net/browse/OCPBUGS-78539
• Reverts OCPBUGS-78539: chore(e2e): add temporary crash toleration for dns-operator #7978

Test plan

• Verify e2e tests pass without the dns-operator crash toleration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 1859fefa-f820-44cd-9394-73f0296f401a

📥 Commits

Reviewing files that changed from the base of the PR and between 8eaac17 and c6ee79a.

📒 Files selected for processing (1)

• test/e2e/util/util.go

💤 Files with no reviewable changes (1)

• test/e2e/util/util.go

---

📝 Walkthrough

Walkthrough

A line containing the dns-operator entry was removed from the podCrashTolerations map in the test utilities file. Previously, this entry specified that the dns-operator pod could tolerate up to 5 restarts during end-to-end testing. With this removal, the dns-operator will no longer have a custom restart tolerance configuration and will instead follow the default behavior for pods not explicitly listed in the map.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jparrill]

/cc @sjenning

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jparrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jparrill]

/hold

Until new dns-operator manifests reach the ocp payload

[jparrill]

/area testing

[jparrill]

/test e2e-azure-self-managed

[openshift-ci]

@jparrill: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.