CNTRLPLANE-2786: Extend controller architecture diagram with consumes relationship#8029
Conversation
The Mermaid diagram in controller-architecture.md lacked an explanation of how resources are consumed (read as input) versus actively reconciled. This made the architecture diagram incomplete for readers trying to understand the full picture of controller interactions. - Add legend entries distinguishing reconciles, creates, operates, and consumes relationship types - Add a dotted "consumes" arrow from CAPI Provider to CAPIInfrastructureMachineTemplate, showing that the provider reads machine templates created by the HyperShift Operator without actively watching or reconciling them - Remove the TODO comment that requested this clarification - Regenerate aggregated docs Ref: CNTRLPLANE-2786 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/auto-cc |
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@hypershift-jira-solve-ci[bot]: This pull request references CNTRLPLANE-2786 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe documentation file defining controller architecture diagrams has been updated to enhance clarity around relationship semantics. Four legend entries were added to explicitly define arrow types used in the diagrams. A new dotted ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@hypershift-jira-solve-ci[bot]: This pull request references CNTRLPLANE-2786 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@hypershift-jira-solve-ci[bot]: This pull request references CNTRLPLANE-2786 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling required tests: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, hypershift-jira-solve-ci[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm cancel |
|
/verify bypass docs only change |
|
/verified bypass |
|
@bryan-cox: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
Pipeline controller notification No second-stage tests were triggered for this PR. This can happen when:
Use |
|
@hypershift-jira-solve-ci: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
The Mermaid diagram in
controller-architecture.mdlacked an explanation of how resources are consumed (read as input) versus actively reconciled. This made the architecture diagram incomplete for readers trying to understand the full picture of controller interactions.Changes:
Which issue(s) this PR fixes:
Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-2786
Special notes for your reviewer:
This is a documentation-only change to the Mermaid architecture diagram. No code changes.
Checklist:
Always review AI generated responses prior to use.
Generated with Claude Code via
/jira:solve [CNTRLPLANE-2786](https://redhat.atlassian.net/browse/CNTRLPLANE-2786)Summary by CodeRabbit