Skip to content

CNTRLPLANE-2786: Extend controller architecture diagram with consumes relationship#8029

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
hypershift-community:fix-CNTRLPLANE-2786
Mar 26, 2026
Merged

CNTRLPLANE-2786: Extend controller architecture diagram with consumes relationship#8029
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
hypershift-community:fix-CNTRLPLANE-2786

Conversation

@hypershift-jira-solve-ci
Copy link
Copy Markdown

@hypershift-jira-solve-ci hypershift-jira-solve-ci bot commented Mar 23, 2026

What this PR does / why we need it:

The Mermaid diagram in controller-architecture.md lacked an explanation of how resources are consumed (read as input) versus actively reconciled. This made the architecture diagram incomplete for readers trying to understand the full picture of controller interactions.

Changes:

  • Add legend entries distinguishing reconciles, creates, operates, and consumes relationship types
  • Add a dotted "consumes" arrow from CAPI Provider to CAPIInfrastructureMachineTemplate, showing that the provider reads machine templates created by the HyperShift Operator without actively watching or reconciling them
  • Remove the TODO comment that requested this clarification
  • Regenerate aggregated docs

Which issue(s) this PR fixes:

Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-2786

Special notes for your reviewer:

This is a documentation-only change to the Mermaid architecture diagram. No code changes.

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Always review AI generated responses prior to use.
Generated with Claude Code via /jira:solve [CNTRLPLANE-2786](https://redhat.atlassian.net/browse/CNTRLPLANE-2786)


Note: This PR was auto-generated by the jira-agent periodic CI job in response to CNTRLPLANE-2786. See the full report for token usage, cost breakdown, and detailed phase output.

Summary by CodeRabbit

  • Documentation
    • Enhanced controller architecture documentation with clarified diagram legend entries defining relationship semantics
    • Updated resource dependency flowchart to illustrate consumption relationships between components

The Mermaid diagram in controller-architecture.md lacked an explanation
of how resources are consumed (read as input) versus actively reconciled.
This made the architecture diagram incomplete for readers trying to
understand the full picture of controller interactions.

- Add legend entries distinguishing reconciles, creates, operates, and
  consumes relationship types
- Add a dotted "consumes" arrow from CAPI Provider to
  CAPIInfrastructureMachineTemplate, showing that the provider reads
  machine templates created by the HyperShift Operator without
  actively watching or reconciling them
- Remove the TODO comment that requested this clarification
- Regenerate aggregated docs

Ref: CNTRLPLANE-2786

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@hypershift-jira-solve-ci
Copy link
Copy Markdown
Author

/auto-cc

@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 23, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 23, 2026

@hypershift-jira-solve-ci[bot]: This pull request references CNTRLPLANE-2786 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

The Mermaid diagram in controller-architecture.md lacked an explanation of how resources are consumed (read as input) versus actively reconciled. This made the architecture diagram incomplete for readers trying to understand the full picture of controller interactions.

Changes:

  • Add legend entries distinguishing reconciles, creates, operates, and consumes relationship types
  • Add a dotted "consumes" arrow from CAPI Provider to CAPIInfrastructureMachineTemplate, showing that the provider reads machine templates created by the HyperShift Operator without actively watching or reconciling them
  • Remove the TODO comment that requested this clarification
  • Regenerate aggregated docs

Which issue(s) this PR fixes:

Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-2786

Special notes for your reviewer:

This is a documentation-only change to the Mermaid architecture diagram. No code changes.

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Always review AI generated responses prior to use.
Generated with Claude Code via /jira:solve [CNTRLPLANE-2786](https://redhat.atlassian.net/browse/CNTRLPLANE-2786)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 9bb62b07-e52b-489f-b406-d0a3c1aac2df

📥 Commits

Reviewing files that changed from the base of the PR and between b17cf16 and 3d3a46a.

⛔ Files ignored due to path filters (1)
  • docs/content/reference/aggregated-docs.md is excluded by !docs/content/reference/aggregated-docs.md
📒 Files selected for processing (1)
  • docs/content/reference/controller-architecture.md

📝 Walkthrough

Walkthrough

The documentation file defining controller architecture diagrams has been updated to enhance clarity around relationship semantics. Four legend entries were added to explicitly define arrow types used in the diagrams. A new dotted consumes relationship type was introduced to represent resources used as inputs or lookups, distinct from resources that trigger reconciliation. The resource dependency flowchart was modified to include a consumes edge from capi-provider to capi-machine-template. A preceding TODO comment expressing uncertainty about representing such input relationships was removed.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 23, 2026

@hypershift-jira-solve-ci[bot]: This pull request references CNTRLPLANE-2786 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

The Mermaid diagram in controller-architecture.md lacked an explanation of how resources are consumed (read as input) versus actively reconciled. This made the architecture diagram incomplete for readers trying to understand the full picture of controller interactions.

Changes:

  • Add legend entries distinguishing reconciles, creates, operates, and consumes relationship types
  • Add a dotted "consumes" arrow from CAPI Provider to CAPIInfrastructureMachineTemplate, showing that the provider reads machine templates created by the HyperShift Operator without actively watching or reconciling them
  • Remove the TODO comment that requested this clarification
  • Regenerate aggregated docs

Which issue(s) this PR fixes:

Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-2786

Special notes for your reviewer:

This is a documentation-only change to the Mermaid architecture diagram. No code changes.

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Always review AI generated responses prior to use.
Generated with Claude Code via /jira:solve [CNTRLPLANE-2786](https://redhat.atlassian.net/browse/CNTRLPLANE-2786)


Note: This PR was auto-generated by the jira-agent periodic CI job in response to CNTRLPLANE-2786. See the full report for token usage, cost breakdown, and detailed phase output.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from csrwng, enxebre and muraee March 23, 2026 08:55
@openshift-ci openshift-ci bot added area/documentation Indicates the PR includes changes for documentation and removed do-not-merge/needs-area labels Mar 23, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 23, 2026

@hypershift-jira-solve-ci[bot]: This pull request references CNTRLPLANE-2786 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:

The Mermaid diagram in controller-architecture.md lacked an explanation of how resources are consumed (read as input) versus actively reconciled. This made the architecture diagram incomplete for readers trying to understand the full picture of controller interactions.

Changes:

  • Add legend entries distinguishing reconciles, creates, operates, and consumes relationship types
  • Add a dotted "consumes" arrow from CAPI Provider to CAPIInfrastructureMachineTemplate, showing that the provider reads machine templates created by the HyperShift Operator without actively watching or reconciling them
  • Remove the TODO comment that requested this clarification
  • Regenerate aggregated docs

Which issue(s) this PR fixes:

Fixes https://redhat.atlassian.net/browse/CNTRLPLANE-2786

Special notes for your reviewer:

This is a documentation-only change to the Mermaid architecture diagram. No code changes.

Checklist:

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Always review AI generated responses prior to use.
Generated with Claude Code via /jira:solve [CNTRLPLANE-2786](https://redhat.atlassian.net/browse/CNTRLPLANE-2786)


Note: This PR was auto-generated by the jira-agent periodic CI job in response to CNTRLPLANE-2786. See the full report for token usage, cost breakdown, and detailed phase output.

Summary by CodeRabbit

  • Documentation
  • Enhanced controller architecture documentation with clarified diagram legend entries defining relationship semantics
  • Updated resource dependency flowchart to illustrate consumption relationships between components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Copy Markdown
Member

@bryan-cox bryan-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2026
@openshift-ci-robot
Copy link
Copy Markdown

Scheduling required tests:
/test e2e-aks-cilium

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, hypershift-jira-solve-ci[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2026
@bryan-cox
Copy link
Copy Markdown
Member

/lgtm cancel

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2026
@bryan-cox
Copy link
Copy Markdown
Member

/verify bypass

docs only change

@bryan-cox
Copy link
Copy Markdown
Member

/verified bypass

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 23, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@bryan-cox: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@enxebre
Copy link
Copy Markdown
Member

enxebre commented Mar 26, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2026
@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

  • The changed files don't match any pipeline_run_if_changed patterns
  • All files match pipeline_skip_if_only_changed patterns
  • No pipeline-controlled jobs are defined for the main branch

Use /test ? to see all available tests.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 26, 2026

@hypershift-jira-solve-ci: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 304806b into openshift:main Mar 26, 2026
8 checks passed
@bryan-cox bryan-cox deleted the fix-CNTRLPLANE-2786 branch March 26, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Indicates the PR includes changes for documentation jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants