Skip to content

Enable self-approval prevention for medik8s org#76650

Open
razo7 wants to merge 1 commit intoopenshift:mainfrom
razo7:medik8s-self-approval
Open

Enable self-approval prevention for medik8s org#76650
razo7 wants to merge 1 commit intoopenshift:mainfrom
razo7:medik8s-self-approval

Conversation

@razo7
Copy link
Member

@razo7 razo7 commented Mar 23, 2026

Why we need this PR:

Prevent PR authors from approving their own PRs via /approve in medik8s repos, enforcing proper code review practices.

Changes made:

Set require_self_approval: true in the medik8s Prow plugin config.

Which issue(s) this PR fixes:

Test plan:

  • After merge, verify that /approve by a PR author is rejected by the approve plugin

@openshift-ci openshift-ci bot requested review from Prucek and hector-vido March 23, 2026 06:51
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2026
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 23, 2026
Prevents PR authors from running /approve on their own PRs via Prow.

Assisted-by: Claude claude-opus-4-6
@razo7 razo7 force-pushed the medik8s-self-approval branch from daaf061 to 4b511b1 Compare March 23, 2026 13:26
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@razo7: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2026

@razo7: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants