Remove e2e-test-registry image build from operator-controller main config by joelanford · Pull Request #78581 · openshift/release

joelanford · 2026-04-29T17:20:39Z

Summary

Remove the e2e-test-registry image build from the main branch CI config for operator-framework-operator-controller
Remove excluded_images from promotion config (no longer needed)
Remove E2E_REGISTRY_IMAGE dependency from openshift-e2e-aws and openshift-e2e-aws-techpreview tests

Test plan

CI passes make update validation
No remaining references to e2e-test-registry in generated job files

Generated with Claude Code

Summary by CodeRabbit

Chores
- Updated CI/CD build configuration to streamline the build and promotion workflow.

coderabbitai · 2026-04-29T17:21:04Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ec2d01aa-2f36-4be4-9e54-89a18c3c32a5

📥 Commits

Reviewing files that changed from the base of the PR and between d3f1867 and 4c4c785.

📒 Files selected for processing (1)

ci-operator/config/openshift/operator-framework-operator-controller/openshift-operator-framework-operator-controller-main.yaml

Walkthrough

The CI/CD workflow configuration for operator-controller no longer builds or promotes the e2e-test-registry image, and the associated e2e test steps no longer depend on or reference this image artifact.

Changes

Cohort / File(s)	Summary
CI/CD Workflow Configuration `ci-operator/config/openshift/operator-framework-operator-controller/openshift-operator-framework-operator-controller-main.yaml`	Removed `e2e-test-registry` image definition, excluded it from the `"5.0"` promotion set, and removed `E2E_REGISTRY_IMAGE` dependency from `openshift-e2e-aws` and `openshift-e2e-aws-techpreview` e2e steps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely describes the main change: removing the e2e-test-registry image build from the operator-controller configuration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies only CI configuration YAML files and does not create, modify, or introduce any Ginkgo test code or declarations.
Test Structure And Quality	✅ Passed	PR only modifies CI configuration YAML files without any Ginkgo test code changes, making the custom check not applicable.
Microshift Test Compatibility	✅ Passed	This PR modifies CI operator configuration (YAML) only, removing image build config and updating test dependencies, but introduces no new Ginkgo e2e test code.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR modifies only CI/CD configuration files without adding any new Ginkgo e2e tests, so the SNO Test Compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies CI configuration file, not deployment manifests or controllers with scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	PR modifies only YAML CI/CD configuration files, removing e2e-test-registry image build entries. No Go source code changes that could emit stdout are introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR modifies CI configuration files to remove e2e-test-registry references. No new Ginkgo e2e tests with IPv4 assumptions are added.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Review rate limit: 9/10 reviews remaining, refill in 6 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

joelanford · 2026-04-29T17:57:34Z

/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-main-images pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws-techpreview

openshift-merge-bot · 2026-04-29T17:57:37Z

@joelanford: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

tmshort · 2026-04-29T18:58:01Z

/lgtm

dtfranz · 2026-04-30T00:55:55Z

/retest

joelanford · 2026-04-30T02:59:33Z

Blocked on openshift/operator-framework-operator-controller#711 — the e2e tests in the project repo still expect E2E_REGISTRY_IMAGE to be passed by CI. Until that PR merges (making the argument optional), removing the E2E_REGISTRY_IMAGE dependency here will break the openshift-e2e-aws and openshift-e2e-aws-techpreview rehearsals.

See the rollout plan for the full sequence.

joelanford · 2026-05-01T01:58:39Z

/retest

joelanford · 2026-05-01T02:08:33Z

/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws
/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws-techpreview

openshift-merge-bot · 2026-05-01T02:08:35Z

@joelanford: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-05-01T02:12:20Z

@joelanford: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command.

dtfranz · 2026-05-01T06:46:06Z

/go/src/github.com/openshift/operator-framework-operator-controller/openshift/operator-controller/build-test-registry.sh operator-controller-e2e docker-registry 
Illegal number of arguments passed

build-test-registry.sh is a script to stand up an image registry within a cluster.
Usage:
  build-test-registry.sh [NAMESPACE] [NAME] [IMAGE]

...assuming the fix to this just needs a bit of time to propagate, I'll kick off the test again.

/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws-techpreview

joelanford · 2026-05-01T16:23:57Z

Looks like default payload rehearsals passed. Let's try TPNU once more...

/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws-techpreview

openshift-merge-bot · 2026-05-01T16:23:59Z

@joelanford: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

joelanford · 2026-05-01T16:58:36Z

/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws-techpreview

openshift-merge-bot · 2026-05-01T16:58:39Z

@joelanford: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

joelanford · 2026-05-04T19:07:09Z

/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws-techpreview

One more try before I start diving into how its possible for TPNU tests to fail while Default tests didn't.

openshift-merge-bot · 2026-05-04T19:07:12Z

@joelanford: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

joelanford · 2026-05-05T17:22:33Z

/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws
/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws-techpreview

Trying both again. Did something change after the Default rehearsal passed that caused the TPNU rehearsal to fail. Also going to separately investigate the TPNU failures in the meantime.

openshift-merge-bot · 2026-05-05T17:22:36Z

@joelanford: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

joelanford · 2026-05-05T19:22:51Z

The openshift-e2e-aws-techpreview rehearsal is failing, but this job is configured as optional: true and always_run: false with no automatic trigger — it only runs when someone manually invokes /test openshift-e2e-aws-techpreview.

The job was manually triggered by a few people back in Sept-Oct 2025 (PRs #483-#505 on operator-controller), and was reportedly passing at the time. However, those GCS artifacts have since been garbage-collected, and the job hasn't been triggered since Oct 2025 (~7 months ago). A lot has changed since then (e.g. BoxcutterRuntime feature gate on TPNU clusters), so there's no way to know from recent history whether this job was still passing before the changes in this PR.

The current failure is a test timeout unrelated to the changes in this PR (e2e tests hang on TechPreviewNoUpgrade clusters with BoxcutterRuntime:true).

joelanford · 2026-05-17T14:40:26Z

/pj-rehearse ack

We're separately dealing with the openshift-e2e-aws-techpreview test here: openshift/operator-framework-operator-controller#723

openshift-merge-bot · 2026-05-17T14:40:29Z

@joelanford: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

joelanford · 2026-05-17T15:06:11Z

/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws

openshift-merge-bot · 2026-05-17T15:06:13Z

@joelanford: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

dtfranz · 2026-05-18T05:44:34Z

/lgtm
/rehearsals-ack

joelanford · 2026-05-19T00:52:36Z

/pj-rehearse ack

openshift-merge-bot · 2026-05-19T00:52:39Z

@joelanford: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-05-19T01:51:28Z

/retest-required

Remaining retests: 0 against base HEAD b9a138c and 2 for PR HEAD 6f43344 in total

openshift-ci · 2026-05-19T01:55:09Z

@joelanford: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/operator-framework-operator-controller/main/openshift-e2e-aws-techpreview	`4c4c785`	link	unknown	`/pj-rehearse pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws-techpreview`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

joelanford · 2026-05-19T02:15:22Z

Waiting on #79315. Will need to rebase after that merges.

openshift-merge-bot · 2026-05-19T08:03:03Z

/retest-required

Remaining retests: 0 against base HEAD 0a69a74 and 1 for PR HEAD 6f43344 in total

…nfig Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

openshift-merge-bot · 2026-05-19T11:29:54Z

[REHEARSALNOTIFIER]
@joelanford: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-operator-framework-operator-controller-main-bindata-check	openshift/operator-framework-operator-controller	presubmit	Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-check-sync-pr-valid	openshift/operator-framework-operator-controller	presubmit	Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-default-catalog-consistency	openshift/operator-framework-operator-controller	presubmit	Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-e2e-aws-olmv1-ext	openshift/operator-framework-operator-controller	presubmit	Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-e2e-aws-techpreview-olmv1-ext	openshift/operator-framework-operator-controller	presubmit	Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-e2e-aws-upgrade-ovn-single-node	openshift/operator-framework-operator-controller	presubmit	Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-e2e-gcp-ovn-upgrade	openshift/operator-framework-operator-controller	presubmit	Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-images	openshift/operator-framework-operator-controller	presubmit	Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-okd-scos-e2e-aws-ovn	openshift/operator-framework-operator-controller	presubmit	Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-okd-scos-images	openshift/operator-framework-operator-controller	presubmit	Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws	openshift/operator-framework-operator-controller	presubmit	Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-openshift-e2e-aws-techpreview	openshift/operator-framework-operator-controller	presubmit	Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-tests-extension	openshift/operator-framework-operator-controller	presubmit	Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-unit	openshift/operator-framework-operator-controller	presubmit	Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-verify	openshift/operator-framework-operator-controller	presubmit	Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-verify-commits	openshift/operator-framework-operator-controller	presubmit	Ci-operator config changed
pull-ci-openshift-operator-framework-operator-controller-main-verify-deps	openshift/operator-framework-operator-controller	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

joelanford · 2026-05-19T11:30:19Z

/pj-rehearse ack

openshift-merge-bot · 2026-05-19T11:30:22Z

@joelanford: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

tmshort · 2026-05-19T13:16:00Z

/lgtm

openshift-ci · 2026-05-19T13:16:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtfranz, joelanford, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/operator-framework-operator-controller/OWNERS~~ [joelanford,tmshort]
~~ci-operator/jobs/openshift/operator-framework-operator-controller/OWNERS~~ [joelanford,tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The e2e-test-registry image is no longer built by CI after openshift/release#78581 removed it from the CI config. The dynamic per-scenario catalog system replaced the pre-built registry image, making this Dockerfile dead code.

openshift-ci Bot requested review from ankitathomas and dtfranz April 29, 2026 17:21

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2026

openshift-ci Bot assigned tmshort Apr 29, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2026

tmshort mentioned this pull request Apr 29, 2026

NO-ISSUE: UPSTREAM: <carry>: remove dead e2e registry push job and related variables openshift/operator-framework-operator-controller#711

Merged

1 task

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 17, 2026

joelanford force-pushed the remove-e2e-test-registry-image branch from 4c4c785 to 6f43344 Compare May 17, 2026 15:02

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 17, 2026

openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 17, 2026

openshift-ci Bot assigned dtfranz May 18, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2026

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 19, 2026

Remove e2e-test-registry image build from operator-controller main co…

956a75d

…nfig Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

joelanford force-pushed the remove-e2e-test-registry-image branch from 6f43344 to 956a75d Compare May 19, 2026 11:26

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 19, 2026

openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 19, 2026

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 19, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2026

openshift-merge-bot Bot merged commit 5887935 into openshift:main May 19, 2026
16 checks passed

joelanford mentioned this pull request May 19, 2026

OPRUN-4608: UPSTREAM: <carry>: Delete openshift/registry.Dockerfile openshift/operator-framework-operator-controller#729

Draft

2 tasks

Conversation

joelanford commented Apr 29, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

joelanford commented Apr 29, 2026

Uh oh!

openshift-merge-bot Bot commented Apr 29, 2026

Uh oh!

tmshort commented Apr 29, 2026

Uh oh!

dtfranz commented Apr 30, 2026

Uh oh!

joelanford commented Apr 30, 2026

Uh oh!

joelanford commented May 1, 2026

Uh oh!

joelanford commented May 1, 2026

Uh oh!

openshift-merge-bot Bot commented May 1, 2026

Uh oh!

openshift-merge-bot Bot commented May 1, 2026

Uh oh!

dtfranz commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joelanford commented May 1, 2026

Uh oh!

openshift-merge-bot Bot commented May 1, 2026

Uh oh!

joelanford commented May 1, 2026

Uh oh!

openshift-merge-bot Bot commented May 1, 2026

Uh oh!

joelanford commented May 4, 2026

Uh oh!

openshift-merge-bot Bot commented May 4, 2026

Uh oh!

joelanford commented May 5, 2026

Uh oh!

openshift-merge-bot Bot commented May 5, 2026

Uh oh!

joelanford commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joelanford commented May 17, 2026

Uh oh!

openshift-merge-bot Bot commented May 17, 2026

Uh oh!

joelanford commented May 17, 2026

Uh oh!

openshift-merge-bot Bot commented May 17, 2026

Uh oh!

dtfranz commented May 18, 2026

Uh oh!

joelanford commented May 19, 2026

Uh oh!

openshift-merge-bot Bot commented May 19, 2026

Uh oh!

openshift-merge-bot Bot commented May 19, 2026

Uh oh!

openshift-ci Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joelanford commented May 19, 2026

Uh oh!

openshift-merge-bot Bot commented May 19, 2026

Uh oh!

openshift-merge-bot Bot commented May 19, 2026

Uh oh!

joelanford commented May 19, 2026

Uh oh!

joelanford commented Apr 29, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 29, 2026 •

edited

Loading

dtfranz commented May 1, 2026 •

edited

Loading

joelanford commented May 5, 2026 •

edited

Loading

openshift-ci Bot commented May 19, 2026 •

edited

Loading