AO3-6811 Fix tag nomination parented bug#5845
Open
pmonfort wants to merge 1 commit into
Open
Conversation
Collaborator
|
Assigning myself as reviewer since I saw some things I want to poke at, but I am beat so that's not gonna happen tonight |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
AO3-1234 Fix thing)Issue
https://otwarchive.atlassian.net/browse/AO3-6811
Purpose
When a canonical tag is saved,
Tag#update_tag_nominationssetsparented: trueon matchingTagNominationrecords.However, it only checked for
Fandom-type parents and only matched nominations with a blankparent_tagname(empty string).This caused nominations to be incorrectly marked as
parented: falsewhen:nilparent_tagnameinstead of an empty string.This PR fixes both issues by:
""andnilin theparent_nameslist so nominations with either blank value are matched.Testing Instructions
parentedfield istrue.Credit
Pablo Monfort (he/him)