fix(web-app-pdf-viewer): [OCISDEV-878] display open button on iOS/iPadOS#13816
Open
LukasHirt wants to merge 2 commits into
Open
fix(web-app-pdf-viewer): [OCISDEV-878] display open button on iOS/iPadOS#13816LukasHirt wants to merge 2 commits into
LukasHirt wants to merge 2 commits into
Conversation
On iOS/iPadOS, we now display a button to open the PDF file in the browser instead of the native PDF viewer. This is a workaround to avoid issues with the native PDF viewer on iOS/iPadOS. Signed-off-by: Lukas Hirt <info@hirt.cz>
mzner
approved these changes
May 28, 2026
Signed-off-by: Lukas Hirt <info@hirt.cz>
Collaborator
Author
|
@mzner I added some unit tests. Could you please review the latest changes? I kept them in separate commit for now so that it's easier to find them. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On iOS/iPadOS, we now display a button to open the PDF file in the browser instead of the native PDF viewer. This is a workaround to avoid issues with the native PDF viewer on iOS/iPadOS.
Related Issue
Motivation and Context
On iOS/iPadOS, the object/iframe approach does not fully work because it always renders only the first page. This makes the viewer unusable. To work around this, an open button allows user to simply open the PDF in a new tab where it works as expected.
How Has This Been Tested?
Screenshots (if appropriate):