[RFC] ReflectionAttribute::getCurrent()#21440
[RFC] ReflectionAttribute::getCurrent()#21440DanielEScherzer wants to merge 4 commits intophp:masterfrom
Conversation
| #[Attribute] | ||
| class Demo { | ||
| public function __construct( $args ) { | ||
| echo ReflectionAttribute::getCurrent(); |
There was a problem hiding this comment.
I think it's more common to use var_dump here.
There was a problem hiding this comment.
Though, I'd also be fine with just echoing the name property/method of the object rather than dumping the whole object. Other internals regulars may have a different opinion...
There was a problem hiding this comment.
I wanted to make it clear that it has the same information that was present to the caller, and var_dump has less information than toString() for reflection objects
|
I believe we'd also want tests to confirm what happens if that method is called outside the constructor, and how it will error (or null, or whatever it's going to do). |
added |
2 participants
No description provided.