Draft
Conversation
derickr
reviewed
Mar 25, 2026
TimWolla
reviewed
Mar 25, 2026
asgrim
commented
Mar 26, 2026
| @@ -0,0 +1,12 @@ | |||
| # PIE downloader | |||
Contributor
Author
There was a problem hiding this comment.
General question to reviewers; what is the earliest version of PHP we could get this into? PIE supports PHP 8.1+, so ideally that, but obviously it is out of support, so won't actually get any new releases. I suppose it would be PHP 8.4+?
Contributor
|
While I'm all in for shipping pie with installations by default, I don't think build time is the place to start a download of a separate project. This seems more of a distribution issue than being related to php itself. Also a bit weird to depend on pie, which has php as a dependency, when building php. Especially in versions that can't even run the phar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--with-pie(or--with-pie=/pie/path) options to./configure; this downloads PIE into the given path (defaults to$$prefix/lib/php/pie).Fixes php/pie#564