Zend/Optimizer/dfa_pass.c: refactor zend_dfa_optimize_calls()#21549
Merged
Girgias merged 2 commits intophp:masterfrom Mar 28, 2026
Merged
Zend/Optimizer/dfa_pass.c: refactor zend_dfa_optimize_calls()#21549Girgias merged 2 commits intophp:masterfrom
Girgias merged 2 commits intophp:masterfrom
Conversation
This function is only called within dfa_pass.c, thus make it static Return a uint32_t as the value can never be negative Add some const qualifiers Minor CS adjustment to make if condition easier to read
iluuu1994
reviewed
Mar 27, 2026
iluuu1994
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is only called within dfa_pass.c, thus make it static
Return a uint32_t as the value can never be negative
Add some const qualifiers
Minor CS adjustment to make if condition easier to read
Noticed this while checking something for #21542