ext/intl: Expose Spoofchecker restriction-level APIs on all supported ICU versions#22055
Open
LamentXU123 wants to merge 2 commits into
Open
ext/intl: Expose Spoofchecker restriction-level APIs on all supported ICU versions#22055LamentXU123 wants to merge 2 commits into
LamentXU123 wants to merge 2 commits into
Conversation
devnexen
reviewed
May 16, 2026
| <?php | ||
| $r = new ReflectionClass("Spoofchecker"); | ||
|
|
||
| var_dump($r->getConstant("ASCII") !== false); |
Member
There was a problem hiding this comment.
Test asserts existence only; that's fine since spoofchecker_007.phpt covers behavior, but asserting the constants are distinct integers would also catch a future
fallback collision.
Contributor
Author
There was a problem hiding this comment.
Added. I don't sure if this time my test is a little bit too verbose
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those constants (functions) are made out of the version guard of ICU >= 58 in this PR.
Fixes #22053