Skip to content

ext/spl: Fix ArrayObject unserialize validation for invalid iterator classes #22090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arshidkv12 wants to merge 2 commits into
base: master
Choose a base branch
from
+20 −1
Open

ext/spl: Fix ArrayObject unserialize validation for invalid iterator classes #22090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
816a47e
ext/spl: Fix ArrayObject unserialize validation for invalid iterator …
arshidkv12 May 19, 2026
2b452cf
ext/spl: Fix ArrayObject unserialize validation for invalid iterator …
arshidkv12 May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/spl/spl_array.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1482,7 +1482,7 @@ PHP_METHOD(ArrayObject, __unserialize)
RETURN_THROWS();
}

if (!instanceof_function(ce, zend_ce_iterator)) {
if (!instanceof_function(ce, spl_ce_ArrayIterator)) {
zend_throw_exception_ex(spl_ce_UnexpectedValueException, 0,
"Cannot deserialize ArrayObject with iterator class '%s'; this class does not implement the Iterator interface",
ZSTR_VAL(Z_STR_P(iterator_class_zv)));
Expand Down
19 changes: 19 additions & 0 deletions ext/spl/tests/GH-22047.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
--TEST--
GH-22047: ArrayObject invalid iterator class in serialized payload
--FILE--
<?php

$payload = 'O:11:"ArrayObject":4:{i:0;i:0;i:1;a:2:{i:4;d:0.0;i:1;b:1;}i:2;a:0:{}i:3;s:12:"GlobIterator";}';

try {
$obj = unserialize($payload);
foreach ($obj as $k => $v) {
echo "should not reach here\n";
}
} catch (UnexpectedValueException $e) {
echo $e->getMessage(), "\n";
}

?>
--EXPECTF--
Cannot deserialize ArrayObject with iterator class 'GlobIterator'; this class does not implement the Iterator interface
Loading