Fix phpstan/phpstan#13705: Adding elements to empty array in while loop does not result in array being recognized as potentially non-empty for in_array

src/Analyser/TypeSpecifier.php

@@ -289,9 +289,15 @@
 					$sizeType = $leftType;
 				}
 
-				$specifiedTypes = $this->specifyTypesForCountFuncCall($expr->right, $argType, $sizeType, $context, $scope, $expr);
-				if ($specifiedTypes !== null) {
-					$result = $result->unionWith($specifiedTypes);
+				// For range-typed left operands in falsey context ($left <= count($right)
+				// being false means count < $left), specifyTypesForCountFuncCall would
+				// incorrectly narrow the array because "count not in sizeType" is stricter
+				// than "count < some value in sizeType range".
+				if (!($context->falsey() && $leftType instanceof IntegerRangeType)) {
+					$specifiedTypes = $this->specifyTypesForCountFuncCall($expr->right, $argType, $sizeType, $context, $scope, $expr);
+					if ($specifiedTypes !== null) {
+						$result = $result->unionWith($specifiedTypes);
+					}
 				}
 
 				if (

tests/PHPStan/Analyser/nsrt/bug-13705.php

@@ -0,0 +1,40 @@
+<?php declare(strict_types = 1);
+
+namespace Bug13705;
+
+use function PHPStan\Testing\assertType;
+
+function whileLoop(): void
+{
+	$quantity = random_int(1, 42);
+	$codes = [];
+	while (count($codes) < $quantity) {
+		assertType('list<non-empty-string>', $codes);
+		$code = random_bytes(16);
+		if (!in_array($code, $codes, true)) {
+			$codes[] = $code;
+		}
+	}
+}
+
+function doWhileLoop(): void
+{
+	$quantity = random_int(1, 42);
+	$codes = [];
+	do {
+		$code = random_bytes(16);
+		if (!in_array($code, $codes, true)) {
+			$codes[] = $code;
+		}
+	} while (count($codes) < $quantity);
+}
+
+function whileLoopSimple(): void
+{
+	$quantity = random_int(1, 42);
+	$codes = [];
+	while (count($codes) < $quantity) {
+		assertType('list<non-empty-string>', $codes);
+		$codes[] = random_bytes(16);
+	}
+}

tests/PHPStan/Analyser/nsrt/bug-4700.php

@@ -21,8 +21,8 @@ function(array $array, int $count): void {
 		assertType('int<1, 5>', count($a));
 		assertType('list{0: mixed~null, 1?: mixed~null, 2?: mixed~null, 3?: mixed~null, 4?: mixed~null}', $a);
 	} else {
-		assertType('0', count($a));
-		assertType('array{}', $a);
+		assertType('int<0, 5>', count($a));
+		assertType('array{}|list{0: mixed~null, 1?: mixed~null, 2?: mixed~null, 3?: mixed~null, 4?: mixed~null}', $a);
 	}
 };
 

tests/PHPStan/Analyser/nsrt/bug11480.php

@@ -106,7 +106,7 @@ public function intRangeCount($count): void
 		if (count($x) >= $count) {
 			assertType("array{'xy'}|array{0: 'ab', 1?: 'xy'}", $x);
 		} else {
-			assertType("array{}", $x);
+			assertType("array{}|array{'xy'}|array{0: 'ab', 1?: 'xy'}", $x);
 		}
 		assertType("array{}|array{'xy'}|array{0: 'ab', 1?: 'xy'}", $x);
 	}