Reduce false positives about constant conditions in traits#5309
Merged
ondrejmirtes merged 10 commits into2.2.xfrom Mar 27, 2026
Merged
Reduce false positives about constant conditions in traits#5309ondrejmirtes merged 10 commits into2.2.xfrom
ondrejmirtes merged 10 commits into2.2.xfrom
Conversation
Collaborator
|
You've opened the pull request against the latest branch 2.2.x. PHPStan 2.2 is not going to be released for months. If your code is relevant on 2.1.x and you want it to be released sooner, please rebase your pull request and change its target to 2.1.x. |
Fixes phpstan/phpstan#13023 Closes phpstan/phpstan#7599 Closes phpstan/phpstan#13023 Closes phpstan/phpstan#13474 Closes phpstan/phpstan#13687 Closes phpstan/phpstan#12798 Closes phpstan/phpstan#11949 Closes phpstan/phpstan#12267 Closes phpstan/phpstan#9515 Closes phpstan/phpstan#4570 Closes phpstan/phpstan#4121 Closes phpstan/phpstan#8060
…nditionInTraitHelper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the result via ConstantConditionInTraitCollector. The ConstantConditionInTraitRule then aggregates
results across all classes using the trait and only reports the error when all usages agree (the
condition is always-true or always-false in every context).
are suppressed as false positives.
across contexts, it's reported once directly in the trait; if messages differ (different type
descriptions per class), each is reported in its context.
Fixes phpstan/phpstan#13023
Closes phpstan/phpstan#7599
Closes phpstan/phpstan#13023
Closes phpstan/phpstan#13474
Closes phpstan/phpstan#13687
Closes phpstan/phpstan#12798
Closes phpstan/phpstan#11949
Closes phpstan/phpstan#12267
Closes phpstan/phpstan#9515
Closes phpstan/phpstan#4570
Closes phpstan/phpstan#4121
Closes phpstan/phpstan#8060
Closes phpstan/phpstan#10353