Update monitor-prometheus-and-grafana-integration-tidb-cloud-dynamic-…#22680
Update monitor-prometheus-and-grafana-integration-tidb-cloud-dynamic-…#22680huoyao1125 wants to merge 1 commit intopingcap:masterfrom
Conversation
…tracker-essential.json
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @huoyao1125. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Code Review
This pull request removes the 'Request Unit' row and 'Resource Group RU' panel from the Grafana dashboard configuration. Feedback indicates that this removal leads to an incomplete dashboard and inconsistency with the internal documentation. It is suggested to update the panel with the correct metric names, such as tidbcloud_resource_manager_resource_unit_read_request_unit, rather than deleting the section entirely.
| ], | ||
| "title": "Resource Group RU", | ||
| "type": "timeseries" | ||
| } |
There was a problem hiding this comment.
The removal of the 'Request Unit' section makes the dashboard incomplete and inconsistent with its internal description (line 55), which states that it includes 'resource unit metrics'. Since these metrics are essential for monitoring TiDB Cloud Essential clusters and are documented as available in the integration guide, you should update the panels to use the current metric names (such as tidbcloud_resource_manager_resource_unit_read_request_unit and tidbcloud_resource_manager_resource_unit_write_request_unit) instead of removing them entirely.
References
- The documentation and associated tools should be complete and technically accurate. (link)
…tracker-essential.json
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?