refact(om2.0): reorder ABFN and enhance comments#2898
Merged
Conversation
Follow up to #2894 Let the metric be name and labels AND sample. Also fix a typo picked up by Claude. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
Improve ABNF readability. Move timestamp and start-timestamp next to sample. Move numbers to one group (integers moved up) and improve comments. Move classic histograms before native histograms. Improve comments on histograms in general. Fix doble negative_spans error. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
added
the
priority/p3
dashpole
previously approved these changes
Mar 18, 2026
bwplotka
approved these changes
Mar 20, 2026
Member
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
LGTM, I have unrelated comments only, so let's merge!
|
|
||
| A GaugeHistogram Sample MUST contain Gcount, Gsum values. | ||
|
|
||
| The GCount value MUST be equal to the number of measurements currently in the GaugeHistogram. The GCount is a gauge semantically. The GCount SHOULD be an integer. The GCount SHOULD NOT be -Inf, +Inf, NAN, or negative. |
Member
There was a problem hiding this comment.
Perhaps "Gcount" but it's unrelated nit for different PR
|
|
||
| metric = metricname-and-labels SP sample | ||
|
|
||
| sample = value [SP timestamp] [SP start-timestamp] *exemplar LF |
Member
There was a problem hiding this comment.
not multiple exemplars (unrelated question to this PR I guess)?
Member
Author
There was a problem hiding this comment.
We agreed to support multiple exemplars for all, if that's what you're asking? Let's quickly discuss at the meeting.
Member
There was a problem hiding this comment.
I meant this ABNF looks like only one exemplar is allowed....?
Member
Author
There was a problem hiding this comment.
The star means zero or any number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve ABNF readability.
Move timestamp and start-timestamp next to sample. Move numbers to one group (integers moved up) and improve comments. Move classic histograms before native histograms. Improve comments on histograms in general. Fix doble negative_spans error.