fix: prevent crash when calling pybind11::print in a subsystem:windows build#6012
Open
oxine wants to merge 2 commits intopybind:masterfrom
Open
fix: prevent crash when calling pybind11::print in a subsystem:windows build#6012oxine wants to merge 2 commits intopybind:masterfrom
oxine wants to merge 2 commits intopybind:masterfrom
Conversation
in line: file = module_::import("sys").attr("stdout"); the file will be none in a windows application build. won't be catched since there's no exception, and crashed in later access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: prevent crash when calling pybind11::print in a subsystem:windows build
Description
Calling pybind11::print() crash in MSVC v19.44 with /subsystem:windows given.
In line:
file = module_::import("sys").attr("stdout");the file will be none in a windows application build. won't be catched since there's no exception, and crashed in later access.Add check before accessing
fileto prevent crash.