refactor(resolver): return lists of matching versions#975
Open
rd4398 wants to merge 1 commit intopython-wheel-build:mainfrom
Open
refactor(resolver): return lists of matching versions#975rd4398 wants to merge 1 commit intopython-wheel-build:mainfrom
rd4398 wants to merge 1 commit intopython-wheel-build:mainfrom
Conversation
rd4398
changed the title
This commit refactors resolution layer to return all matching versions instead of a single
version, laying the groundwork for multiple version bootstrap support.
Changes:
- resolver.resolve() and resolve_from_provider() now return list[tuple[str, Version]]
instead of single tuple, sorted by version (highest first)
- sources.resolve_source() returns all matching source versions as list
- wheels.resolve_prebuilt_wheel() returns all matching wheel versions as list
- RequirementResolver methods updated to handle and cache lists
- Bootstrapper.resolve_version() picks highest version ([0]) maintaining exact
backward compatibility
- Graph resolution (_resolve_from_graph) returns all matching versions from
previous bootstrap
- Cache keys remain (requirement_string, pre_built) but now store full lists
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Rohan Devasthale <rdevasth@redhat.com>
rd4398
force-pushed
the
resolver-return-multiple-values
branch
from
31d3717 to
8fe05f7
Compare
Collaborator
|
The PR changes a lot of code and introduces an API-incompatible change. Alternative:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors resolution layer to return all matching versions instead of a single
version, laying the groundwork for multiple version bootstrap support.
Changes: