gh-125895: Render 404 page correctly on docs.python.org#147984
Merged
StanFromIreland merged 1 commit intopython:mainfrom Apr 3, 2026
Merged
gh-125895: Render 404 page correctly on docs.python.org#147984StanFromIreland merged 1 commit intopython:mainfrom
docs.python.org#147984StanFromIreland merged 1 commit intopython:mainfrom
Conversation
hugovk
approved these changes
Apr 3, 2026
StanFromIreland
added
needs backport to 3.13
|
Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 3, 2026
…pythonGH-147984) (cherry picked from commit 80ab6d9) Co-authored-by: Stan Ulbrych <stan@python.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 3, 2026
…pythonGH-147984) (cherry picked from commit 80ab6d9) Co-authored-by: Stan Ulbrych <stan@python.org>
|
GH-148040 is a backport of this pull request to the 3.14 branch. |
|
GH-148041 is a backport of this pull request to the 3.13 branch. |
Member
Author
|
The 404 page is colourful now:-) 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With python/psf-salt#637, nginx will serve the per-version 404.html page. However, it will render without styling/JS since
sphinx-notfound-pagedefaults to referencing static assets under/en/latest/, this fixes that.📚 Documentation preview 📚: https://cpython-previews--147984.org.readthedocs.build/