gh-146636: PEP 803: Reference documentation#148013
gh-146636: PEP 803: Reference documentation#148013encukou wants to merge 7 commits intopython:mainfrom
Conversation
ZeroIntensity
left a comment
There was a problem hiding this comment.
Congrats on the PEP acceptance :)
Mostly editorial comments from me. The content generally looks good.
Doc/c-api/module.rst
Outdated
| In the :ref:`Stable ABI <stable-abi>` for Free-Threaded Builds (``abi3t``), | ||
| this struct is opaque, and unusable in practice. | ||
| The struct, including all members, is part of Stable ABI for | ||
| non-free-threaded builds (``abi3``). |
There was a problem hiding this comment.
Why is "Free-Threaded Builds" in title case, but then "non-free-threaded builds" isn't?
Doc/c-api/stable.rst
Outdated
|
|
||
| .. c:macro:: Py_LIMITED_API | ||
| - ``abi3``, introduced in Pyton 3.2, is compatible with | ||
| **non**-:term:`free threaded <free-threaded build>` builds of CPython. |
There was a problem hiding this comment.
Nitpicky, but I believe "free threaded" needs a dash here. In the original issue where we added the "free-threaded build" term (#144277), we determined that no dash was correct only when "free threaded" was a noun.
| Note that compiling for Stable ABI is *not* a complete guarantee that code will | ||
| be compatible with the expected Python versions. | ||
| Stable ABI prevents *ABI* issues, like linker errors due to missing |
There was a problem hiding this comment.
I think we need to precede "Stable ABI" with "the"?
| Note that compiling for Stable ABI is *not* a complete guarantee that code will | |
| be compatible with the expected Python versions. | |
| Stable ABI prevents *ABI* issues, like linker errors due to missing | |
| Note that compiling for the Stable ABI is *not* a complete guarantee that code will | |
| be compatible with the expected Python versions. | |
| The Stable ABI prevents *ABI* issues, like linker errors due to missing |
There was a problem hiding this comment.
Even if there's two of them?
There was a problem hiding this comment.
Yeah, not too sure about the rules here. What about "the Stable ABIs"?
Doc/c-api/stable.rst
Outdated
| symbols or data corruption due to changes in structure layouts or function | ||
| signatures. | ||
| However, other changes in Python can change the *behavior* of extensions. | ||
| See Python's Backwards Compatibility Policy (:pep:`387`) for details. |
There was a problem hiding this comment.
This sentence confused me a little when I first read it. I had read it as "We might change the behavior of extensions -- go read our backward compatibility policy if you want to know what", but then we provide an example right after the reader was diverted. Could we move this sentence to after the following paragraph, or put it in a seealso note?
Doc/whatsnew/3.15.rst
Outdated
| C extensions that target the :ref:`Stable ABI <stable-abi>` can now be | ||
| compiled for the new *Stable ABI for Free-Threaded Builds* (also known | ||
| as ``abi3t``), which makes them compatible with | ||
| :term:`free-threaded build <free-threaded build>` builds of CPython. |
There was a problem hiding this comment.
| :term:`free-threaded build <free-threaded build>` builds of CPython. | |
| :term:`free-threaded <free-threaded build>` builds of CPython. |
Doc/whatsnew/3.15.rst
Outdated
| part of the instance struct; and | ||
| - Switching from a ``PyInit_`` function to a new export hook, | ||
| :c:func:`PyModExport_* <PyModExport_modulename>`, introduced for this | ||
| purpose in :pep:`903`. |
There was a problem hiding this comment.
| purpose in :pep:`903`. | |
| purpose in :pep:`803`. |
Doc/whatsnew/3.15.rst
Outdated
| :c:func:`PyModExport_* <PyModExport_modulename>`, introduced for this | ||
| purpose in :pep:`903`. | ||
|
|
||
| Note that Stable ABI does not offer all functionality CPython has to offer. |
There was a problem hiding this comment.
| Note that Stable ABI does not offer all functionality CPython has to offer. | |
| Note that the Stable ABI does not offer all the functionality that CPython has to offer. |
Or if you don't like "the" before "Stable ABI":
| Note that Stable ABI does not offer all functionality CPython has to offer. | |
| Note that Stable ABI does not offer all the functionality that CPython has to offer. |
Doc/whatsnew/3.15.rst
Outdated
| be selected in a build tool (such as Setuptools, ``meson-python``, Cython, | ||
| Scikit-build-core, Maturin, and similar). |
There was a problem hiding this comment.
Is it intentional that meson-python is the only package in a code block here?
Doc/whatsnew/3.15.rst
Outdated
| be selected in a build tool (such as Setuptools, ``meson-python``, Cython, | ||
| Scikit-build-core, Maturin, and similar). | ||
| At the time of writing this entry, these tools did **not** support ``abi3t``. | ||
| If this is the case for "your" tool, compile for ``cp315t`` separately. |
There was a problem hiding this comment.
Hm, why is "your" in quotes?
|
The new check caught removals: https://github.com/python/cpython/actions/runs/23907059205/job/69719041532?pr=148013 (and on your PR out of everyone's ;-) |
| There are two Stable ABIs: | ||
|
|
||
| .. c:macro:: Py_LIMITED_API | ||
| - ``abi3``, introduced in Pyton 3.2, is compatible with |
There was a problem hiding this comment.
| - ``abi3``, introduced in Pyton 3.2, is compatible with | |
| - ``abi3``, introduced in Python 3.2, is compatible with |
|
|
||
| Define this macro before including ``Python.h`` to opt in to only use | ||
| the Limited API, and to select the Limited API version. | ||
| - ``abi3t``, introduced in Pyton 3.15, is compatible with |
There was a problem hiding this comment.
| - ``abi3t``, introduced in Pyton 3.15, is compatible with | |
| - ``abi3t``, introduced in Python 3.15, is compatible with |
| signatures. | ||
| However, other changes in Python can change the *behavior* of extensions. | ||
| See Python's Backwards Compatibility Policy (:pep:`387`) for details. | ||
| When using a build tool (for example, ``setuptools``), the tool is |
There was a problem hiding this comment.
| When using a build tool (for example, ``setuptools``), the tool is | |
| When using a build tool (for example, Setuptools), the tool is |
| Typically, you should choose a specific value rather than the version of | ||
| the Python headers you are compiling against. | ||
|
|
||
| The macro(s) must be defined before including ``Python.h``. |
There was a problem hiding this comment.
"(s)" is a bit awkward, prefer a generic singular or plural:
| The macro(s) must be defined before including ``Python.h``. | |
| The macros must be defined before including ``Python.h``. |
| .. c:macro:: Py_TARGET_ABI3T | ||
|
|
||
| Target ``abi3t``, that is, | ||
| :term:`free-threaded <free-threaded build>` builds of CPython. |
There was a problem hiding this comment.
| :term:`free-threaded <free-threaded build>` builds of CPython. | |
| :term:`free-threaded builds <free-threaded build>` of CPython. |
|
|
||
| Limited API Scope and Performance | ||
| --------------------------------- | ||
| On a a :term:`free-threaded build` -- that is, when |
There was a problem hiding this comment.
| On a a :term:`free-threaded build` -- that is, when | |
| On a :term:`free-threaded build` -- that is, when |
| C extensions that target the :ref:`Stable ABI <stable-abi>` can now be | ||
| compiled for the new *Stable ABI for Free-Threaded Builds* (also known | ||
| as ``abi3t``), which makes them compatible with | ||
| :term:`free-threaded <free-threaded build>` builds of CPython. |
There was a problem hiding this comment.
| :term:`free-threaded <free-threaded build>` builds of CPython. | |
| :term:`free-threaded builds <free-threaded build>` of CPython. |
|
|
||
| Stable ABI for Free-Threaded Builds should typically | ||
| be selected in a build tool (such as Setuptools, meson-python, Cython, | ||
| Scikit-build-core, Maturin, and similar). |
There was a problem hiding this comment.
Don't really need "and similar" after "such as".
| Scikit-build-core, Maturin, and similar). | |
| scikit-build-core, Maturin). |
| Stable ABI for Free-Threaded Builds should typically | ||
| be selected in a build tool (such as Setuptools, meson-python, Cython, | ||
| Scikit-build-core, Maturin, and similar). | ||
| At the time of writing this entry, these tools did **not** support ``abi3t``. |
There was a problem hiding this comment.
| At the time of writing this entry, these tools did **not** support ``abi3t``. | |
| At the time of writing, these tools did **not** support ``abi3t``. |
ngoldbaum
left a comment
There was a problem hiding this comment.
Thanks for putting this together! I left a few comments inline, please take them or leave them as you see fit.
| defined this way. | ||
|
|
||
| In the :ref:`Stable ABI <stable-abi>` for free-threaded builds (``abi3t``), | ||
| this struct is opaque, and unusable in practice. |
There was a problem hiding this comment.
This is all covered above, but for people who land here with a direct link to this section, you could add a cross-reference suggesting the PyModExport API instead?
| When using a build tool (for example, ``setuptools``), the tool is | ||
| generally responsible for setting macros and synchronizing them with | ||
| extension filenames and other metadata. | ||
| Prefer using the tool's options over defining the macros manually. |
There was a problem hiding this comment.
Maybe setuptools is a poor example to use above then? Because setuptools expects users to set the build flags manually...
You could delete the "(For example, SetupTools)" above, or maybe refer to meson-python or scikit-build-core instead? These days that's what I recommend to people depending on if they already use CMake or not.
|
|
||
| Target ``abi3t``, that is, | ||
| :term:`free-threaded <free-threaded build>` builds of CPython. | ||
| See :ref:`above <abi3-compiling>` for common information. |
There was a problem hiding this comment.
Maybe add "The free-threaded and GIL-enabled can both load abi3t extensions".
|
|
||
| The goal for the Limited API is to allow everything that is possible with the | ||
| - define both :c:macro:`!Py_LIMITED_API` and :c:macro:`!Py_TARGET_ABI3T`, or | ||
| - define only :c:macro:`!Py_LIMITED_API` and build for free-threaded Python. |
There was a problem hiding this comment.
| - define only :c:macro:`!Py_LIMITED_API` and build for free-threaded Python. | |
| - Define only :c:macro:`!Py_LIMITED_API` and define :c:macro:`!Py_GIL_DISABLED`. | |
| This happens automatically with a free-threaded interpreter, except on Windows. |
| free-threading (``cp315t``) separately. | ||
|
|
||
| Stable ABI for Free-Threaded Builds should typically | ||
| be selected in a build tool (such as Setuptools, meson-python, Cython, |
There was a problem hiding this comment.
Maybe split this between build backends and bindings generators? Both probably need configuration.
It's a little confusing to group Cython in with meson-python.
📚 Documentation preview 📚: https://cpython-previews--148013.org.readthedocs.build/