Skip to content

pyserial: read_all cannot return None? #15620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshareddy832 wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −1
Open

pyserial: read_all cannot return None? #15620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82ab856
fix: pyserial: read_all cannot return none? (#15619)
harshareddy832 Apr 7, 2026
2a49a8c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 7, 2026
f8a2358
fix: pyserial: read_all cannot return none? (#15619)
harshareddy832 Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .claude/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"attribution": {
"commit": "",
"pr": ""
}
}
Comment thread
harshareddy832 marked this conversation as resolved.
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ analyze.py
.idea/
.venv*/

# Claude Code
.claude/
Comment on lines +68 to +69
Copy link
Copy Markdown
Collaborator

@srittau srittau May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm fine with adding .claude to .gitignore, this should be done in a separate PR to keep our git history clean.


# Mypy cache
.mypy_cache/

Expand Down
2 changes: 1 addition & 1 deletion stubs/pyserial/serial/serialutil.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,6 @@ class SerialBase(io.RawIOBase):
def apply_settings(self, d: dict[str, Any]) -> None: ...
def readinto(self, buffer: WriteableBuffer, /) -> int: ... # returns int unlike `io.RawIOBase`
def send_break(self, duration: float = 0.25) -> None: ...
def read_all(self) -> bytes | None: ...
def read_all(self) -> bytes: ...
def read_until(self, expected: bytes = b"\n", size: int | None = None) -> bytes: ...
def iread_until(self, expected: bytes = ..., size: int | None = ...) -> Generator[bytes]: ...
Loading