[ExecuTorch][MmapDataLoader] Issue F_RDADVISE on Apple platforms in UseMadvise path#19587
Open
pytorchbot wants to merge 1 commit into
Open
[ExecuTorch][MmapDataLoader] Issue F_RDADVISE on Apple platforms in UseMadvise path#19587pytorchbot wants to merge 1 commit into
pytorchbot wants to merge 1 commit into
Conversation
…seMadvise path Pull Request resolved: #19554 In the MmapDataLoader UseMadvise codepath, after the existing madvise(MADV_WILLNEED | MADV_SEQUENTIAL) calls, also issue fcntl(F_RDADVISE) on Apple platforms (iOS/macOS). F_RDADVISE is more aggressive than madvise for cold starts: it schedules read-ahead on the file descriptor itself, bringing pages into the unified buffer cache so first-touch faults during inference are serviced from RAM instead of storage. F_RDADVISE closes part of the gap between lazy mmap and eager file read, while still allowing pages to be evicted under memory pressure (unlike mlock, which pins pages and counts against RLIMIT_MEMLOCK). Differential Revision: [D104318326](https://our.internmc.facebook.com/intern/diff/D104318326/) ghstack-source-id: 381778987
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19587
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 79942a8 with merge base 3a5e285 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #19554 by @kimishpatel
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/241/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/241/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/kimishpatel/240/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/kimishpatel/241/orig
Differential Revision: D104318326
@diff-train-skip-merge