Skip to content

Arm backend: Stabilize MobileNetV3 fp16 TOSA test#19590

Merged
bdemirb merged 2 commits into
pytorch:mainfrom
bdemirb:fix-mv3-fp16-flaky-tolerance
May 18, 2026
Merged

Arm backend: Stabilize MobileNetV3 fp16 TOSA test#19590
bdemirb merged 2 commits into
pytorch:mainfrom
bdemirb:fix-mv3-fp16-flaky-tolerance

Conversation

@bdemirb
Copy link
Copy Markdown
Collaborator

@bdemirb bdemirb commented May 14, 2026

This patch fixes a flaky MobileNetV3 fp16 TOSA test caused by
unseeded random input data and a tolerance that was slightly too
tight for observed fp16 backend differences.

The test input is now generated with a local fixed torch.Generator so
the model comparison is deterministic across runs. The fp16 absolute
tolerance is relaxed from 5e-2 to 6e-2, covering the observed maximum
absolute error while keeping the check narrow.

The regression was verified with the targeted MobileNetV3 fp16 TOSA
pytest case.

Signed-off-by: Baris Demir <[email protected]>
Change-Id: Ie89950adc108fd2d93763e75b28c8668f7435ab8
@bdemirb bdemirb requested a review from digantdesai as a code owner May 14, 2026 15:56
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 14, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19590

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 1 Cancelled Job, 3 Unrelated Failures

As of commit 8b6ff2e with merge base 803e47d (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 14, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels May 14, 2026
@bdemirb
Copy link
Copy Markdown
Collaborator Author

bdemirb commented May 14, 2026

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot Bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label May 14, 2026
@bdemirb
Copy link
Copy Markdown
Collaborator Author

bdemirb commented May 14, 2026

@pytorchbot label "release notes: arm"

@pytorch-bot pytorch-bot Bot added the release notes: arm Changes to the ARM backend delegate label May 14, 2026
@bdemirb bdemirb merged commit 3c68b67 into pytorch:main May 18, 2026
435 of 444 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants