Add a16w8 per-op test for conv1d#19597
Open
christine-long-meta wants to merge 2 commits into
Open
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19597
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 5 New FailuresAs of commit 64cd4d2 with merge base 824cbff ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
|
christine-long-meta
force-pushed
the
export-D104532360
branch
from
cf08707 to
400371e
Compare
This PR needs a
|
christine-long-meta
force-pushed
the
export-D104532360
branch
from
400371e to
19cf8db
Compare
meta-codesync
Bot
changed the title
christine-long-meta
force-pushed
the
export-D104532360
branch
2 times, most recently
from
cf08707 to
2f54bac
Compare
christine-long-meta
added a commit
to christine-long-meta/executorch
that referenced
this pull request
May 14, 2026
Summary:
Add int16 activation / int8 weight (a16w8) quantization tests for `aten.conv1d` on Ethos-U55 and Ethos-U85.
## Changes
- Add `a16w8_conv1d_test_parameters` dict with 14 test configurations (7 conv configs × {per_channel_quant=True, False}) covering kernel sizes 1/3/5, stride 1/2, dilation, depthwise, and no-bias variants
- Add `test_conv1d_a16w8_u55_INT` using `EthosU55PipelineINT` with `a16w8_quantization=True, symmetric_io_quantization=True, per_channel_quantization=<varied>, qtol=128, epsilon=2**-16`
- Add `test_conv1d_a16w8_u85_INT` using `EthosU85PipelineINT` with same kwargs
- Register `ops/test_conv1d.py` in `fbcode/` and `xplat/` `targets.bzl`
bypass-pytorch-oss-checks
Differential Revision: D104532360
christine-long-meta
force-pushed
the
export-D104532360
branch
from
2f54bac to
d52c255
Compare
Contributor
|
@christine-long-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104532360. |
christine-long-meta
force-pushed
the
export-D104532360
branch
3 times, most recently
from
f5f9e2d to
66dc761
Compare
Contributor
|
@christine-long-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104532360. |
2 similar comments
Contributor
|
@christine-long-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104532360. |
Contributor
|
@christine-long-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104532360. |
meta-codesync
Bot
changed the title
christine-long-meta
force-pushed
the
export-D104532360
branch
3 times, most recently
from
1719ccc to
c6484aa
Compare
meta-codesync
Bot
changed the title
christine-long-meta
force-pushed
the
export-D104532360
branch
2 times, most recently
from
318aeb1 to
09b0ebf
Compare
Summary: Add int16 activation / int8 weight (a16w8) quantization tests for `aten.var` on Ethos-U55 and Ethos-U85. ## Changes - Add `test_var_a16w8_u55_INT` using `EthosU55PipelineINT` with `a16w8_quantization=True, symmetric_io_quantization=True`, reusing existing `Var.test_parameters` (4 test configurations) - Add `test_var_a16w8_u85_INT` using `EthosU85PipelineINT` with same kwargs - Register `ops/test_var.py` in `fbcode/` and `xplat/` `targets.bzl` bypass-pytorch-oss-checks Differential Revision: D104532362
Summary: Add int16 activation / int8 weight (a16w8) quantization tests for `aten.conv1d` on Ethos-U55 and Ethos-U85. ## Changes - Add `test_conv1d_a16w8_u55_INT` using `EthosU55PipelineINT` with `a16w8_quantization=True, symmetric_io_quantization=True`, reusing existing `test_data_INT` parameters - Add `test_conv1d_a16w8_u85_INT` using `EthosU85PipelineINT` with same kwargs - Register `ops/test_conv1d.py` in `fbcode/` and `xplat/` `targets.bzl` Reviewed By: Ninja91 Differential Revision: D104532360
christine-long-meta
force-pushed
the
export-D104532360
branch
from
09b0ebf to
64cd4d2
Compare
meta-codesync
Bot
changed the title
zingo
approved these changes
May 18, 2026
Collaborator
zingo
left a comment
zingo
left a comment
There was a problem hiding this comment.
Test seem to pass now, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add int16 activation / int8 weight (a16w8) quantization tests for
aten.conv1don Ethos-U55 and Ethos-U85.Changes
test_conv1d_a16w8_u55_INTusingEthosU55PipelineINTwitha16w8_quantization=True, symmetric_io_quantization=True, reusing existingtest_data_INTparameterstest_conv1d_a16w8_u85_INTusingEthosU85PipelineINTwith same kwargsops/test_conv1d.pyinfbcode/andxplat/targets.bzlReviewed By: Ninja91
Differential Revision: D104532360