Skip to content

chore: upgrade father plugin #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zombieJ merged 1 commit into from
May 18, 2026
Merged

chore: upgrade father plugin #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"gh-pages": "npm run docs:build && npm run docs:deploy",
"lint": "eslint src --ext .tsx,.ts,.jsx,.js",
"now-build": "npm run docs:build",
"prepublishOnly": "npm run compile && np --yolo --no-publish",
"prepublishOnly": "npm run compile && rc-np",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The rc-np command is a publishing tool. Removing the --yolo --no-publish flags in the prepublishOnly script will cause rc-np to attempt a full publish flow whenever npm publish is called, which leads to a recursive loop. These flags should be retained to ensure rc-np only performs checks and preparation without triggering a nested publish.

Suggested change
"prepublishOnly": "npm run compile && rc-np",
"prepublishOnly": "npm run compile && rc-np --yolo --no-publish",

"prettier": "prettier . --write",
"postpublish": "npm run gh-pages",
"start": "dumi dev",
Expand All @@ -49,7 +49,8 @@
"@babel/runtime": "^7.24.4"
},
"devDependencies": {
"@rc-component/father-plugin": "^1.0.2",
"@rc-component/father-plugin": "^2.2.0",
"@rc-component/np": "^1.0.3",
"@types/jest": "^29.5.12",
"@types/react": "18.x",
"@types/react-dom": "18.x",
Expand All @@ -59,7 +60,6 @@
"father": "^4.4.0",
"gh-pages": "^6.1.1",
"lint-staged": "^15.2.2",
"np": "^10.0.3",
"prettier": "^3.2.5",
"rc-test": "^7.0.15",
"react": "^18.2.0",
Expand Down
Loading