[php 8.3] Add json_validate rule

Author: Arshid

phpunit.xml

@@ -6,6 +6,7 @@
     colors="true"
     executionOrder="defects"
     defaultTestSuite="main"
+             stopOnError="true"
     displayDetailsOnTestsThatTriggerWarnings="true"
     displayDetailsOnPhpunitDeprecations="true"
 >

rules-tests/CodeQuality/Rector/Class_/InlineConstructorDefaultToPropertyRector/Fixture/skip_complex_assign.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector\Fixture;
+
+final class SkipComplexAssign
+{
+    private $name;
+
+    public function __construct($name)
+    {
+        $this->name = $name;
+    }
+}

rules/Php83/Rector/BooleanAnd/JsonValidateRector.php

@@ -12,9 +12,7 @@
 use PhpParser\Node\Expr\ConstFetch;
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Name;
-use PHPStan\Analyser\Scope;
 use Rector\NodeManipulator\BinaryOpManipulator;
-use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\Php71\ValueObject\TwoNodeMatch;
 use Rector\PhpParser\Node\Value\ValueResolver;
 use Rector\Rector\AbstractRector;
@@ -89,14 +87,9 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        $scope = $node->getAttribute(AttributeKey::SCOPE);
-        if (! $scope instanceof Scope) {
-            return null;
-        }
-
         $args = $funcCall->getArgs();
 
-        if ($args === []) {
+        if (count($args) < 1 ){
             return null;
         }
 

tests/bootstrap.php

@@ -7,11 +7,7 @@
 require_once __DIR__ . '/../vendor/autoload.php';
 
 // silent deprecations, since we test them
-// error_reporting(E_ALL ^ E_DEPRECATED);
-error_reporting(E_ALL);
-set_error_handler(function (int $severity, string $message, string $file, int $line): bool {
-    throw new \ErrorException($message, 0, $severity, $file, $line);
-});
+error_reporting(E_ALL ^ E_DEPRECATED);
 
 // performance boost
 gc_disable();