Skip to content

fix(ci): fix argo-cd-backend plugin package name in showcase-sanity-plugins#4783

Open
gustavolira wants to merge 1 commit intoredhat-developer:release-1.9from
gustavolira:release-1.9
Open

fix(ci): fix argo-cd-backend plugin package name in showcase-sanity-plugins#4783
gustavolira wants to merge 1 commit intoredhat-developer:release-1.9from
gustavolira:release-1.9

Conversation

@gustavolira
Copy link
Copy Markdown
Member

Summary

  • Fixes the showcase-sanity-plugins CI job failing on release-1.9 due to a missing -dynamic suffix in the argocd-backend plugin package path
  • The installer was trying to npm pack from ./dynamic-plugins/dist/roadiehq-backstage-plugin-argo-cd-backend which does not exist; the correct path is roadiehq-backstage-plugin-argo-cd-backend-dynamic
  • This is a release-1.9-specific issue — the main branch already uses the correct -dynamic suffix

Root cause

install-dynamic-plugins.py failed with:

npm error enoent Could not read package.json: Error: ENOENT: no such file or directory,
open '/opt/app-root/src/dynamic-plugins/dist/roadiehq-backstage-plugin-argo-cd-backend/package.json'

The {{inherit}} removal from PR #4731 was not needed here — verified that all OCI plugins with {{inherit}} in this file are still present in the quay.io/rhdh/plugin-catalog-index:1.9 catalog index with their bs_1.45.3__X.Y.Z tags.

Test plan

  • showcase-sanity-plugins CI job passes on release-1.9

🤖 Generated with Claude Code

…lugins

The dist package path was missing the -dynamic suffix, causing the
install-dynamic-plugins.py script to fail with ENOENT when trying to
npm pack the non-existent directory.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@rhdh-qodo-merge
Copy link
Copy Markdown

rhdh-qodo-merge Bot commented May 8, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2026

@rhdh-qodo-merge
Copy link
Copy Markdown

Review Summary by Qodo

Fix argo-cd-backend plugin package name suffix in showcase-sanity-plugins

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Fixes missing -dynamic suffix in argo-cd-backend plugin package path
• Resolves install-dynamic-plugins.py ENOENT error on release-1.9
• Corrects package reference from roadiehq-backstage-plugin-argo-cd-backend to
  roadiehq-backstage-plugin-argo-cd-backend-dynamic
Diagram
flowchart LR
  A["CI Pipeline Configuration"] -->|"Update package path"| B["Add -dynamic suffix"]
  B -->|"Correct path"| C["roadiehq-backstage-plugin-argo-cd-backend-dynamic"]
  C -->|"Resolves"| D["install-dynamic-plugins.py ENOENT error"]
Loading

Grey Divider

File Changes

1. .ci/pipelines/value_files/diff-values_showcase-sanity-plugins.yaml 🐞 Bug fix +1/-1

Add -dynamic suffix to argo-cd-backend package path

• Updated argo-cd-backend plugin package path to include -dynamic suffix
• Changed from ./dynamic-plugins/dist/roadiehq-backstage-plugin-argo-cd-backend to
 ./dynamic-plugins/dist/roadiehq-backstage-plugin-argo-cd-backend-dynamic
• Fixes CI job failure caused by missing package directory during npm pack operation

.ci/pipelines/value_files/diff-values_showcase-sanity-plugins.yaml


Grey Divider

Qodo Logo

@gustavolira
Copy link
Copy Markdown
Member Author

/test ?

1 similar comment
@gustavolira
Copy link
Copy Markdown
Member Author

/test ?

@gustavolira
Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm-nightly

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Image was built and published successfully. It is available at:

@gustavolira
Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm-nightly

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 9, 2026

@gustavolira: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm-nightly ca1d22f link false /test e2e-ocp-helm-nightly

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gustavolira
Copy link
Copy Markdown
Member Author

Fixed sanity plugins check, now the tests are passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant