Support Redis URI#208
Conversation
|
@shacharPash This PR should include a couple of examples, specifically in the readme, for ease of connection, like other redis-clients |
| // TODO: add tests | ||
|
|
||
| [SkipIfRedis(Is.OSSCluster, Comparison.LessThan, "7.1.242")] | ||
| public void TestDefaultLibName() |
There was a problem hiding this comment.
IMHO this should be RedisUriParserTests, to align with the other class. Simlarly, let's add a mass coverage matrix. Can something like this work?
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #208 +/- ##
==========================================
- Coverage 94.10% 93.93% -0.18%
==========================================
Files 85 88 +3
Lines 5178 5276 +98
Branches 487 494 +7
==========================================
+ Hits 4873 4956 +83
- Misses 178 188 +10
- Partials 127 132 +5 ☔ View full report in Codecov by Sentry. |
|
This pull request has been automatically marked as stale due to inactivity. |
Closes #202
Closes #204