fix(electron): preserve window bounds on reload#1417
Open
rajanarahul93 wants to merge 2 commits intoresponsively-org:mainfrom
Open
fix(electron): preserve window bounds on reload#1417rajanarahul93 wants to merge 2 commits intoresponsively-org:mainfrom
rajanarahul93 wants to merge 2 commits intoresponsively-org:mainfrom
Conversation
a639f9a to
5b54453
Compare
Author
|
Hi @manojVivek, this PR fixes the issue where the window would maximize after a reload on Windows. The reload action now preserves the window's bounds by saving its size and position before reload and restoring them once the content finishes loading. This ensures a consistent window state even when snapped. Happy to make any refinements if needed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
📓 Referenced Issue
Fixes: #999
ℹ️ About the PR
This PR resolves an issue on Windows where the application window would incorrectly maximize after a reload if it was snapped to the side of the screen.
The fix introduces a managed reload process:
menu/view.tsno longer callsreload()directly. Instead, it sends an IPC message (window-reload) to the main process.main.tscatches this message. It saves the window's current bounds (size and position), executes the reload, and then restores the saved bounds once the content has finished loading (on thedid-finish-loadevent).This ensures the window's state is preserved across reloads, providing a consistent user experience.