fix: resolve window focus and build issues on Windows#1494
Open
AlissonFA wants to merge 1 commit intoresponsively-org:mainfrom
Open
fix: resolve window focus and build issues on Windows#1494AlissonFA wants to merge 1 commit intoresponsively-org:mainfrom
AlissonFA wants to merge 1 commit intoresponsively-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Pull Request
📓 Referenced Issue
N/A
ℹ️ About the PR
This PR fixes a Windows focus issue where Responsively could flash in the taskbar and require a second click before the existing app window was brought to the foreground.
The previous Windows focus workaround listened for focus/blur events and programmatically called
blur()followed byfocus(). In practice, that could cancel the first foreground attempt and leave the app flashing instead of opening immediately.This PR replaces that behavior with a simpler and more predictable window activation flow:
It also keeps the single-instance behavior so launching Responsively again brings the existing window forward instead of opening another instance.
Additionally, this PR fixes the Windows production build by enabling glob handling in the source-map cleanup script used before packaging.
🖼️ Testing Scenarios / Screenshots
Tested on Windows by generating and installing a packaged
.exe.Validation performed:
corepack yarn run typecheckcorepack yarn testcorepack yarn package --config.win.signAndEditExecutable=falseManual scenarios tested: