fix Storybook dark preview background#563
Merged
Merged
Conversation
brandur
approved these changes
May 8, 2026
Storybook's `preview-body.html` was trying to inject nested `html` and `body` tags. Browsers strip that structure in the preview iframe, so the dark background never applied and dark-mode UI changes were reviewed against the wrong canvas. Replace the invalid markup with a small style block that targets the real preview `body`, and use `.dark body` so it follows Storybook's theme class on the root element. This makes dark-mode component previews match the app background and gives UI changes a trustworthy review surface.
bgentry
force-pushed
the
bg/storybook-upgrade
branch
from
fcd5161 to
cde9fcb
Compare
bgentry
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storybook's preview body file used nested
htmlandbodytags, but browsers discard that structure inside the preview iframe. As a result, dark-mode stories could render on the wrong background and make visual review misleading.This replaces the invalid markup with a small style block that targets the actual preview
body, including the root.darkclass that Storybook applies for dark mode.