fix(frontend): navigation during open popover breaks closing animation

[jog1t]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[jog1t]

• refactor(frontend): sleep/schedule/wake actions on actors #5092
• refactor(frontend): bring back the billing gauge #5091
• fix(frontend): remove create actor from context switcher #5090
• fix(frontend): dark mode issues on health check monitor #5088
• fix(frontend): custom actor icons not displaying #5083
• refactor(frontend): unify settings pages #5082
• fix(frontend): re-layout members screen #5081
• fix(frontend): navigation during open popover breaks closing animation #5080 👈 (View in Graphite)
• fix(frontend): hover animation on project cards not moving billing badge #5079
• fix(frontend): missing skeleton view for actor names #5078
• fix(frontend): ensure onboarding checks are only for production namespace, improve caching #5077
• fix(frontend): fix changelog display #5076
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: Navigation During Open Popover Breaks Closing Animation

Summary

This PR adds a closeAnimation prop to PopoverContent, DropdownMenuContent, and DropdownMenuSubContent to allow immediate unmounting instead of waiting for exit animations. This fixes a UX bug where navigating during an open popover/dropdown causes the menu to linger while TanStack Router's async beforeLoad transition holds the old tree on-screen.

---

Strengths

• Correct diagnosis: The root cause (Radix keeps the component mounted for its exit animation while Router holds the old tree) is accurately identified and documented in the inline comments.
• Backward-compatible API: closeAnimation?: boolean defaults to true, so no existing callers are affected.
• Consistent application: The prop is uniformly applied across all three component variants and all four affected call sites (context-switcher.tsx, user-dropdown.tsx).
• Good inline documentation: Each usage site has a comment explaining why closeAnimation={false} is needed, which satisfies the "non-obvious WHY" comment convention.

---

Issues

Verify async beforeLoad on all navigated routes

The comments at each call site state that the route has an async beforeLoad. If any of those routes only have sync setup, the comment is misleading and the fix is unnecessary (though harmless). Worth a quick verification against the route definitions.

Missing test coverage

There are no tests verifying:

• The closeAnimation prop defaults to true (backward compat)
• The conditional Tailwind classes are correctly applied/omitted
• The menu actually unmounts immediately when navigating (vs. lingering with animation)

Given the fix targets a timing interaction between Radix and the router, a test (even a simple Vitest snapshot or a component test) would help prevent regression.

Empty PR description

The PR body is unfilled (just the template). The code comments are thorough, but the PR description is the canonical place for future maintainers to understand motivation without reading each change. Please fill it in.

---

CLAUDE.md Conventions Check

Convention	Status
Comments are complete sentences with proper punctuation	✓
No new unnecessary imports	✓
Follows existing patterns in neighboring files	✓
No breaking changes	✓

---

Performance / Security

• Negligible performance impact (conditional class string concat).
• No security implications (pure UI/CSS animation control).
• The fix actually improves perceived performance by eliminating frozen/lingering UI during router transitions.

---

Verdict

Clean, well-reasoned fix. Safe to merge after:

1. Confirming the relevant routes have async beforeLoad (or updating the comments if not)
2. Filling in the PR description

[jog1t]

Merge activity

• May 21, 8:51 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• May 21, 8:59 PM UTC: Graphite rebased this pull request as part of a merge.
• May 21, 8:59 PM UTC: @jog1t merged this pull request with Graphite.