[Python] Decouple Pythonizations from CPyCppyy internals via public API#21694
Merged
guitargeek merged 2 commits intoroot-project:masterfrom Mar 27, 2026
Merged
[Python] Decouple Pythonizations from CPyCppyy internals via public API#21694guitargeek merged 2 commits intoroot-project:masterfrom
guitargeek merged 2 commits intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 8h 31m 43s ⏱️ For more details on these failures, see this check. Results for commit f50a5db. ♻️ This comment has been updated with latest results. |
aaronj0
approved these changes
Mar 26, 2026
Contributor
aaronj0
left a comment
aaronj0
left a comment
There was a problem hiding this comment.
For the new public APIs in CPyCppyy - LGTM!
Replace most direct usage of CPyCppyy internal headers and implementation details in PyROOT with calls to the public CPyCppyy API. This removes implicit coupling between PyROOT and CPyCppyy internals, improves ABI robustness, and clarifies the boundary between the two components while preserving existing functionality.
The `Utiliy::GetBuffer` function from CPyCppyy is an overkill for the simple usecase in the ROOT Pythonization library. We can have our own helper there, avoiding yet another usage of internal CPyCppyy functions.
Contributor
Author
|
Resolved merge conflicts. @vepadulano, is this PR also okay for you? |
vepadulano
approved these changes
Mar 27, 2026
Member
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
LGTM in general, just a minor question for clarification, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace most direct usage of CPyCppyy internal headers and implementation details in PyROOT with calls to the public CPyCppyy API.
This removes implicit coupling between PyROOT and CPyCppyy internals, improves ABI robustness, and clarifies the boundary between the two components while preserving existing functionality.