Skip to content

[builtins] download instead of bundle xxhash and bump from 0.8.0 to 0.8.3#21806

Open
ferdymercury wants to merge 5 commits intoroot-project:masterfrom
ferdymercury:xxh
Open

[builtins] download instead of bundle xxhash and bump from 0.8.0 to 0.8.3#21806
ferdymercury wants to merge 5 commits intoroot-project:masterfrom
ferdymercury:xxh

Conversation

@ferdymercury
Copy link
Copy Markdown
Collaborator

@ferdymercury ferdymercury commented Apr 7, 2026

following xrootd structure

@ferdymercury ferdymercury changed the title [skip-ci,builtins] download instead of bundle xxhash [builtins] download instead of bundle xxhash Apr 7, 2026
@dpiparo dpiparo self-assigned this Apr 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Test Results

    22 files      22 suites   3d 1h 20m 33s ⏱️
 3 833 tests  3 832 ✅  1 💤 0 ❌
75 650 runs  75 632 ✅ 18 💤 0 ❌

Results for commit e1a35795.

♻️ This comment has been updated with latest results.

@ferdymercury ferdymercury force-pushed the xxh branch 2 times, most recently from e0dd829 to 29d679c Compare April 7, 2026 13:31
@ferdymercury ferdymercury changed the title [builtins] download instead of bundle xxhash [builtins] download instead of bundle xxhash and bump from 0.8.0 to 0.8.3 Apr 7, 2026
@dpiparo
Copy link
Copy Markdown
Member

dpiparo commented Apr 10, 2026

thanks. I propose to also add builtin_xxhash to https://github.com/root-project/root/blob/master/.github/workflows/root-ci-config/buildconfig/alma10-clang_ninja.txt in order to test the changes on linux w/o resorting to the system library.

@ferdymercury ferdymercury added the clean build Ask CI to do non-incremental build on PR label Apr 12, 2026
add CMakeLists patch

rm bundled copy

move to LCG

thanks to dpiparo

Mimick other compression builtins

find required dep, too

[builtins] use URL variable

[cmake] use https lcg url
to check no conflicts with system library
as suggested by dpiparo
matches 6.40 release notes and openssl behavior

[cmake] simplify check
@ferdymercury ferdymercury removed the clean build Ask CI to do non-incremental build on PR label Apr 12, 2026
Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
@guitargeek
Copy link
Copy Markdown
Contributor

@ferdymercury, this PR has conflicts now that need to be resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants