Skip to content

Add tests isolation in rclcpp/test#3081

Merged
fujitatomoya merged 1 commit intoros2:rollingfrom
JEnoch:isolate_rmw_zenoh_tests
Feb 21, 2026
Merged

Add tests isolation in rclcpp/test#3081
fujitatomoya merged 1 commit intoros2:rollingfrom
JEnoch:isolate_rmw_zenoh_tests

Conversation

@JEnoch
Copy link
Copy Markdown
Contributor

@JEnoch JEnoch commented Feb 20, 2026

Description

As discussed in ros2/rmw_zenoh#881 (comment), this PR adds tests isolation to all tests initializing a Context or a Node, in order to start a Zenoh router in case of rmw_zenoh_cpp.

On my host before this fix:

  • 900 warning logs "Unable to connect to a Zenoh router"
  • Total Test time (real) = 770.40 sec

After this fix:

  • 0 warning logs "Unable to connect to a Zenoh router"
  • Total Test time (real) = 480.62 sec

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Signed-off-by: Julien Enoch <[email protected]>
@jmachowinski
Copy link
Copy Markdown
Collaborator

Pulls: #3081
Gist: https://gist.githubusercontent.com/jmachowinski/fa1812f776c35c714a3518aaccf3898f/raw/209e1340f8bbe105ed534f8cdcdd033c9447c17e/ros2.repos
BUILD args:
TEST args:
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18280

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Copy Markdown
Collaborator

windows failures are not related to this PR, https://ci.ros2.org/job/ci_windows/26763/#showFailuresLink

@fujitatomoya fujitatomoya merged commit 87be5fb into ros2:rolling Feb 21, 2026
3 checks passed
@JEnoch JEnoch deleted the isolate_rmw_zenoh_tests branch February 25, 2026 10:52
@cottsay
Copy link
Copy Markdown
Member

cottsay commented Apr 13, 2026

@Mergifyio backport kilted

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 13, 2026

backport kilted

✅ Backports have been created

Details

Cherry-pick of 87be5fb has failed:

On branch mergify/bp/kilted/pr-3081
Your branch is up to date with 'origin/kilted'.

You are currently cherry-picking commit 87be5fb.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclcpp/test/rclcpp/CMakeLists.txt

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify bot pushed a commit that referenced this pull request Apr 13, 2026
Signed-off-by: Julien Enoch <[email protected]>
(cherry picked from commit 87be5fb)

# Conflicts:
#	rclcpp/test/rclcpp/CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants