Skip to content

Emit on_kw for ripper#4057

Merged
kddnewton merged 1 commit intoruby:mainfrom
Earlopain:on-kw
Apr 1, 2026
Merged

Emit on_kw for ripper#4057
kddnewton merged 1 commit intoruby:mainfrom
Earlopain:on-kw

Conversation

@Earlopain
Copy link
Copy Markdown
Collaborator

yard uses it

Start checking against the ordering of the events and also their location. The order of the emitted events is very important for yard.

I didn't fix any of the preexisting failures and just ignored them. Some are easy to fix, others look like particularities of ripper that I don't think anyone would rely on. Will see which ones are actually revelent and worth the effort to fix later.

Still, it also relies on on_sp. Will have to see what to do about that. For now I'm adding the easier events it wants that are missing.

`yard` uses it

Start checking against the ordering of the events and also their location.

I didn't fix any of the preexisting failures and just ignored them. Some are easy to fix, others look like particularities of ripper
that I don't think anyone would rely on.
@kddnewton kddnewton merged commit 0808b31 into ruby:main Apr 1, 2026
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants