Skip to content

Reenable sorbet in CI #4061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kddnewton merged 1 commit into from
Apr 2, 2026
Merged

Reenable sorbet in CI #4061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ jobs:
with:
ruby-version: "3.4"
bundler-cache: true
# - name: Check Sorbet
# run: bundle exec rake typecheck:tapioca typecheck:sorbet
- name: Check Sorbet
run: bundle exec rake typecheck:tapioca typecheck:sorbet
- name: Check Steep
run: bundle exec rake typecheck:steep
- name: Check field kinds
Expand Down
4 changes: 2 additions & 2 deletions rakelib/check_manifest.rake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ task check_manifest: :templates do
compile_commands.json
include/prism/config.h
lib/prism/prism.{so,bundle,jar}
sig/_*/*.rbs
sig/**/_*/*.rbs
rbi/_shims/*.rbi
sig/_shims/*.rbs
tags
]

Expand Down
11 changes: 11 additions & 0 deletions rbi/_shims/spoom.rbi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# typed: strict

# Spoom hasn't yet adopted ErrorRecoveryNode
module Prism
class MissingNode < Node; end

class Visitor
sig { params(node: MissingNode).void }
def visit_missing_node(node); end
end
end