Open
Conversation
Use Dir.mktmpdir block form in spec_helper to automatically create and cleanup temp directories for all specs. Removes duplicate setup from individual spec files. Co-Authored-By: Claude Opus 4.5 <[email protected]>
dduugg
approved these changes
Mar 28, 2026
Contributor
dduugg
left a comment
dduugg
left a comment
There was a problem hiding this comment.
It would probably be better to restore the output directory, if you feel inspired, but this is fine as is. Thanks for your contribution!
More robust and future-proof to restore the previous state rather than destroying it. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Author
|
@dduugg iterated! gtg here or would you like to iterate on anything else? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec_helper.rbusingDir.mktmpdirblock formsinged_spec.rbandspec/support/sidekiq.rb🤖 Generated with Claude Code