storage: start streaming zip/index uploads, parallel directory upload#3289
Open
syphar wants to merge 3 commits intorust-lang:mainfrom
Open
storage: start streaming zip/index uploads, parallel directory upload#3289syphar wants to merge 3 commits intorust-lang:mainfrom
syphar wants to merge 3 commits intorust-lang:mainfrom
Conversation
github-actions
bot
added
the
S-waiting-on-review
Member
Author
|
checking the failing tests |
syphar
force-pushed
the
stream-upload-again
branch
2 times, most recently
from
541e7df to
1c3d4a3
Compare
syphar
force-pushed
the
stream-upload-again
branch
from
1c3d4a3 to
f469216
Compare
This comment has been minimized.
This comment has been minimized.
syphar
force-pushed
the
stream-upload-again
branch
from
f469216 to
eb94110
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed version of #3287
the first two commits are the ones from the original PR (cherry-picked), the last commit is the updated functionality.
Generally I tried to go more in the direction of the s3 sdk itself. When using it with a local tempfile, it can just stream-upload it, including retries.
The upload was still hanging when testing this directly with S3 (not with minio). My current assumption is that this is a bug between the s3 sdk & s3 itself. The sdk switches to a streaming checksum calculation when uploading a local file, which doesn't complete in my tests. Easiest workaround: calculate the checksum ourselves (or disable checksums, which I don't like).
When I see the data from the updated
uploaded_filesmetric we can see if we could actually remove our often we retry uploads, currently I believe we can drop our own retries and rely on the sdk-internal retries.