Skip to content

needless_bitwise_bool: suggest a smaller diff#16714

Open
ada4a wants to merge 1 commit intorust-lang:masterfrom
ada4a:push-qkmqlwxvskur
Open

needless_bitwise_bool: suggest a smaller diff#16714
ada4a wants to merge 1 commit intorust-lang:masterfrom
ada4a:push-qkmqlwxvskur

Conversation

@ada4a
Copy link
Copy Markdown
Contributor

@ada4a ada4a commented Mar 14, 2026

changelog: [needless_bitwise_bool]: suggest a smaller diff

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 14, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 14, 2026

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: 7 candidates
  • 7 candidates expanded to 7 candidates
  • Random selection from Jarcho, dswij, llogiq, samueltardieu

@ada4a
Copy link
Copy Markdown
Contributor Author

ada4a commented Mar 14, 2026

let's get to this after #16443 is merged

@rustbot label S-blocked

@rustbot rustbot added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Mar 14, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 14, 2026

Lintcheck changes for a82f77b

Lint Added Removed Changed
clippy::needless_bitwise_bool 0 0 3

This comment will be updated if you push new changes

@ada4a ada4a force-pushed the push-qkmqlwxvskur branch from 7d817fb to e9188d5 Compare March 14, 2026 21:24
@ada4a
Copy link
Copy Markdown
Contributor Author

ada4a commented Mar 23, 2026

nit: confirm the machine-applicable &&/|| suggestion still anchors cleanly when the binop sits inside larger clippy fix bundles.

You mean when the original binary expression spans multiple lines? Or when this fix is applied before/after some other one? I don't think we currently have the infrastructure to test the latter, but it should work fine I think™

@rustbot

This comment has been minimized.

@ada4a ada4a force-pushed the push-qkmqlwxvskur branch from e9188d5 to a82f77b Compare April 11, 2026 11:39
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 11, 2026

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants