perf: reduce matching_root_macro_call usage (23b -> 22.24b)#16756
Merged
Jarcho merged 1 commit intorust-lang:masterfrom Mar 24, 2026
Merged
perf: reduce matching_root_macro_call usage (23b -> 22.24b)#16756Jarcho merged 1 commit intorust-lang:masterfrom
matching_root_macro_call usage (23b -> 22.24b)#16756Jarcho merged 1 commit intorust-lang:masterfrom
Conversation
`matching_root_macro_call` was taking up lots of instructions.
This PR reduces its usage and thus, the number of instructions.
Profiled in `wasmi`. 23,010,846,019 icount -> 22,245,910,522 icount
**-3.324%** performance improvement!
3 Lints were affected:
- `repeat_vec_with_capacity`: 783,874,512 -> 24,488,225
- `string_patterns`: Not measured in benchmark.
- `filter_map`: Weirdly went from 22,000,078 to 22,017,509. But this
doesn't make sense so it's completely anecdotal. (In no world would changing
a function call with a boolean check make *anything* more expensive.
changelog:[`repeat_vec_with_capacity`]: Optimize by 96.876%
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
blyxyas
added
the
G-performance-project
blyxyas
changed the title
matching_root_macro_call usagematching_root_macro_call usage (23b -> 22.24b)
Jarcho
approved these changes
Mar 24, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matching_root_macro_callwas taking up lots of instructions. This PR reduces its usage and thus, the number of instructions.Profiled in
wasmi. 23,010,846,019 icount -> 22,245,910,522 icount -3.324% performance improvement!3 Lints were affected:
-
repeat_vec_with_capacity: 783,874,512 -> 24,488,225-
string_patterns: Not measured in benchmark.-
filter_map: Weirdly went from 22,000,078 to 22,017,509. But this doesn't make sense so it's completely anecdotal. (In no world would changing a function call with a boolean check make anything more expensive.changelog:[
repeat_vec_with_capacity]: Optimize by 96.876%