Rename smart_pointers and conversions exercises with numeric prefix#2391
Closed
foxfromworld wants to merge 1 commit intorust-lang:mainfrom
Closed
Rename smart_pointers and conversions exercises with numeric prefix#2391foxfromworld wants to merge 1 commit intorust-lang:mainfrom
foxfromworld wants to merge 1 commit intorust-lang:mainfrom
Conversation
Update rustlings-macros/info.toml and dev/Cargo.toml accordingly
Contributor
|
Just to clarify, I'm not an official maintainer. This approach still needs an OK from Mo. |
Contributor
|
You can already see in the screenshot that this is not consistent with other sections like |
Author
Understood, thanks for clarifying. I’ll follow the existing convention (Option A) in future contributions. For reference, here’s how I plan to rename the files to align with the convention: |
Contributor
|
Yes, I would merge that :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the maintainer’s guidance in issue #2023, applied Option B (numeric prefix + topic name) for exercises in
smart_pointersandconversions.Changes:
Verification:
cargo checkcargo testcargo run --bin rustlingscargo run -- run 1_box1→ exercise loads and runs successfullycargo run -- run 2_rc1→ exercise loads and runs successfullycargo run -- run 3_arc1→ exercise loads and runs successfullycargo run -- run 4_cow1→ exercise loads and runs successfullycargo run -- run 1_using_as→ exercise loads and runs successfullycargo run -- run 2_from_into→ exercise loads and runs successfullycargo run -- run 3_from_str→ exercise loads and runs successfullycargo run -- run 4_try_from_into→ exercise loads and runs successfullycargo run -- run 5_as_ref_mut→ exercise loads and runs successfully-Screenshots and logs attached for reference.
