Apply Option A naming for smart_pointers and conversions exercises#2393
Open
foxfromworld wants to merge 2 commits intorust-lang:mainfrom
Open
Apply Option A naming for smart_pointers and conversions exercises#2393foxfromworld wants to merge 2 commits intorust-lang:mainfrom
foxfromworld wants to merge 2 commits intorust-lang:mainfrom
Conversation
Update rustlings-macros/info.toml and dev/Cargo.toml accordingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the maintainer’s guidance in issue #2023, applied Option A for exercises in smart_pointers and conversions.
Changes:
For clarity, here’s the rename mapping:
19_smart_pointers
box1.rs -> smart_pointers1.rs
rc1.rs -> smart_pointers2.rs
arc1.rs -> smart_pointers3.rs
cow1.rs -> smart_pointers4.rs
23_conversions
using_as.rs -> conversions1.rs
from_into.rs -> conversions2.rs
from_str.rs -> conversions3.rs
try_from_into.rs -> conversions4.rs
as_ref_mut.rs -> conversions5.rs
Verification:
All exercises load and run successfully, and cargo verify passes without errors.
Screenshots and logs attached for reference:
Ran
cargo checkRan
cargo testRan
cargo run --bin rustlingsRan
cargo run -- run smart_pointers1Ran
cargo run -- run smart_pointers2Ran
cargo run -- run smart_pointers3Ran
cargo run -- run smart_pointers4Ran
cargo run -- run conversions1Ran
cargo run -- run conversions2Ran
cargo run -- run conversions3Ran
cargo run -- run conversions4Ran
cargo run -- run conversions5