Add next_u128 and try_next_u128 to Rng and TryRng respectively#78
Closed
Apersoma wants to merge 4 commits into
Closed
Add next_u128 and try_next_u128 to Rng and TryRng respectively#78Apersoma wants to merge 4 commits into
next_u128 and try_next_u128 to Rng and TryRng respectively#78Apersoma wants to merge 4 commits into
Conversation
Author
|
It may also make sense to implement it via |
Member
|
Closing as per the comment in the parent issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
Added methods to
RngandTryRngto for direct generation of u128s.Motivation
See: #77
Details
Functions
next_u128andtry_next_u128that generate a u128.To ensure backwards-compatibility a default implementation was
added that works by concating 2 u64s generated from calls to
(try_)next_u64. The implementation fortry_next_u128prioritizesreducing branching over reducing calls to
try_next_u64.