Skip to content

upki: add binary index to improve performance#89

Merged
djc merged 1 commit intomainfrom
index
Apr 15, 2026
Merged

upki: add binary index to improve performance#89
djc merged 1 commit intomainfrom
index

Conversation

@djc
Copy link
Copy Markdown
Member

@djc djc commented Mar 20, 2026

No description provided.

@djc djc requested a review from ctz March 20, 2026 10:56
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 20, 2026

Merging this PR will not alter performance

✅ 4 untouched benchmarks


Comparing index (37c0f1f) with main (7460f0d)

Open in CodSpeed

@djc djc force-pushed the index branch 4 times, most recently from fb63488 to 0ccf415 Compare March 20, 2026 11:34
@djc
Copy link
Copy Markdown
Member Author

djc commented Mar 20, 2026

So apparently this doesn't actually improve performance in revocation-check? Codspeed has it unchanged (but mentions it is ignoring time spent in syscalls, which might be problematic for this). Criterion locally assesses it as a ~7% regression, which I'm assuming includes time spent in syscalls?

@djc djc force-pushed the index branch 4 times, most recently from 61cb762 to 8502177 Compare March 20, 2026 12:06
Copy link
Copy Markdown
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good in substance and structure, just would like to understand the performance element more.

@djc djc force-pushed the index branch 2 times, most recently from c56a859 to eedab61 Compare April 2, 2026 14:41
@ctz ctz mentioned this pull request Apr 9, 2026
@djc djc force-pushed the index branch 2 times, most recently from 70f8f1a to b5bd2d8 Compare April 10, 2026 10:37
@djc
Copy link
Copy Markdown
Member Author

djc commented Apr 10, 2026

I did more work on this. It is now ~5% faster than the main branch in my testing on macOS. That still feels a little underwhelming but I tried a bunch of further optimizations and didn't find anything with substantial impact.

About 60% of the time in Index::check() is spent on deserializing CRLiteClubcard, so it probably makes sense to focus on the new encoding instead.

@djc djc requested a review from ctz April 13, 2026 13:25
@djc djc added this pull request to the merge queue Apr 15, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 15, 2026
@djc djc added this pull request to the merge queue Apr 15, 2026
Merged via the queue into main with commit c272726 Apr 15, 2026
9 checks passed
@djc djc deleted the index branch April 15, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants