Skip to content

test(runLint): adjust harmless codes#1604

Merged
scop merged 1 commit intoscop:mainfrom
yedayak:runlint-harmless
Apr 2, 2026
Merged

test(runLint): adjust harmless codes#1604
scop merged 1 commit intoscop:mainfrom
yedayak:runlint-harmless

Conversation

@yedayak
Copy link
Copy Markdown
Collaborator

@yedayak yedayak commented Mar 26, 2026

These are false positives found by runLint. These are harmless but can be updated not to be captured as false positive.

  • The command list for _comp_complete_longopt has not been properly folded at column 79. We can update the line breaking. As a result, "grep" does not appear at the beginning of the line, which is accidental but fine.
  • Prefixing "command" should be harmless because "command" is POSIX.

Originally in #1584

These are false positives found by runLint.  These are harmless but
can be updated not to be captured as false positive.

* The command list for _comp_complete_longopt has not been properly
  folded at column 79.  We can update the line breaking.  As a result,
  "grep" does not appear at the beginning of the line, which is
  accidental but fine.
* Prefixing "command" should be harmless because "command" is POSIX.
@yedayak yedayak mentioned this pull request Mar 26, 2026
@akinomyoga
Copy link
Copy Markdown
Collaborator

Thank you for separating the commit. I forgot it.

@akinomyoga akinomyoga requested a review from scop March 27, 2026 03:59
@akinomyoga
Copy link
Copy Markdown
Collaborator

As I created this change originally, I would like a review from @scop.

Copy link
Copy Markdown
Owner

@scop scop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@scop scop merged commit 1309562 into scop:main Apr 2, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants